Bug 11228

Summary: Explanation on 'patron notification' is not quite right
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: SerialsAssignee: Katrin Fischer <katrin.fischer>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: colin.campbell, fridolin.somers, gmcharlt, nengard, tomascohen
Version: 3.14   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Screenshot of subscription add form
Bug 11228: Improve hint on patron notification when adding/editing subscriptions
Bug 11228: Improve hint on patron notification when adding/editing subscriptions
Bug 11228: Improve hint on patron notification when adding/editing subscriptions

Description Katrin Fischer 2013-11-09 21:49:34 UTC
Created attachment 22849 [details]
Screenshot of subscription add form

The subscription details form states as explanation for the patron notifications pull down:

"Select a notice and patrons on the routing list will be notified when new issues are received."

This is not quite right, as the notices will only be sent out when you have subscribed to them from the OPAC. The routing list patrons won't receive the notice unless they have subscribed before.

In that context the notices template named RLIST should be renamed too, so this is less confusing.
Comment 1 Katrin Fischer 2013-12-05 01:17:19 UTC
I have done some more digging to make sure, that routing lists and patron notification are unrelated. From reading the code this is the case, I have looked at getalert, SendAlerts and addalert - there is no reference to routing lists.
Comment 2 Katrin Fischer 2013-12-05 21:10:37 UTC Comment hidden (obsolete)
Comment 3 Galen Charlton 2013-12-18 22:51:40 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2013-12-19 09:49:37 UTC
Created attachment 23666 [details] [review]
Bug 11228: Improve hint on patron notification when adding/editing subscriptions

The hint was not quite correct, as it said patrons on the routing list
would be informed, but it's only the patrons that have subscribed to
email notifications in the OPAC who will receive the email when a
new serial issue is received.

To test:
- Add a new subscription, find the hint about patron notification on the form
- Apply patch
- Refresh page
- Verify the new hint text makes sense and is correct

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 5 Galen Charlton 2013-12-19 15:10:46 UTC
Pushed to master.  Thanks, Katrin!
Comment 6 Fridolin Somers 2014-01-27 12:44:40 UTC
Patch pushed to 3.14.x, will be in 3.14.3.
Comment 7 Nicole C. Engard 2014-02-05 19:02:45 UTC
Can someone confirm that this edit to the manual is correct: http://git.koha-community.org/gitweb/?p=kohadocs.git;a=commitdiff;h=29377fa98448112cc7b138e9dd6c5960c7500c1c