Bug 11267

Summary: default notices should not be allowed to be deleted
Product: Koha Reporter: Nicole C. Engard <nengard>
Component: NoticesAssignee: Bugs List <koha-bugs>
Status: RESOLVED DUPLICATE QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: dcook, jonathan.druart, katrin.fischer
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12008
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:

Description Nicole C. Engard 2013-11-18 16:20:51 UTC
I have an error where a new library didn't know what some notices were for so they deleted them.  Now if they get a hold and try to print the hold slip they get:


Software error:

Could not find a letter called 'HOLD_PRINT' in the 'reserves' module at /home/koha/kohaclone/C4/Reserves.pm line 1914.



I don't think that any notice that is installed with Koha by default should be allowed to be deleted since they're all there for a reason.
Comment 1 Jonathan Druart 2015-04-23 16:00:38 UTC
I can imagine some cases where they could be deleted.
For instance if you create specific letters for each branch, you don't need the default "all libraries" letters.
Or if you want to be sure the letter won't never use.
Comment 2 Katrin Fischer 2015-05-15 21:50:17 UTC
I agree with Jonathan - For example there is no other way to turn off the suggestion related notice templates than deleting them. And some notices are not strict about the code - like the overdue notices can really use any code, as long as they are defined in the notice triggers.

We'd probably need to make only some non-deleteable. Or have a nicer error message telling the librarian to create a new notice with code X instead of having Koha explode.
Comment 3 David Cook 2022-12-06 05:53:14 UTC
Quite a few important slips cannot be deleted now in master
Comment 4 Jonathan Druart 2022-12-06 06:17:48 UTC

*** This bug has been marked as a duplicate of bug 17355 ***