Summary: | Saving preferences - Nothing to Save | ||
---|---|---|---|
Product: | Koha | Reporter: | Christopher Brannon <cbrannon> |
Component: | System Administration | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, gmcharlt, jonathan.druart, tomascohen, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 11464: Prevent wrong "nothing to save" message on saving syspref
[Signed-off] Bug 11464: Prevent wrong "nothing to save" message on saving syspref [PASSED QA] Bug 11464: Prevent wrong "nothing to save" message on saving syspref |
Description
Christopher Brannon
2013-12-31 23:05:22 UTC
Created attachment 38426 [details] [review] Bug 11464: Prevent wrong "nothing to save" message on saving syspref Sometime you get the "Nothing to save" message when clicking on the "save all preferences" button, even if something has changed. On irritating behavior is the middle click: if you use the middle click to paste some text in the input, the "keyup" event won't be trigger. This patch replaces the "keyup" event with the "change", which works as we want here. The issues: 1/ Search for "wanted" (admin/preferences.pl?op=search&searchfield=wanted) Empty the input, click save Type something and remove it You are able to save, but nothing has changed 2/ Put something in your selection buffer and use the middle click to paste it in the input. No change detected. Test plan: Confirm the issues are fixed and you don't find any regression Note that now the "(modified)" string is displayed when the input loses the focus. Created attachment 38462 [details] [review] [Signed-off] Bug 11464: Prevent wrong "nothing to save" message on saving syspref Sometime you get the "Nothing to save" message when clicking on the "save all preferences" button, even if something has changed. On irritating behavior is the middle click: if you use the middle click to paste some text in the input, the "keyup" event won't be trigger. This patch replaces the "keyup" event with the "change", which works as we want here. The issues: 1/ Search for "wanted" (admin/preferences.pl?op=search&searchfield=wanted) Empty the input, click save Type something and remove it You are able to save, but nothing has changed 2/ Put something in your selection buffer and use the middle click to paste it in the input. No change detected. Test plan: Confirm the issues are fixed and you don't find any regression Note that now the "(modified)" string is displayed when the input loses the focus. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 38616 [details] [review] [PASSED QA] Bug 11464: Prevent wrong "nothing to save" message on saving syspref Sometime you get the "Nothing to save" message when clicking on the "save all preferences" button, even if something has changed. On irritating behavior is the middle click: if you use the middle click to paste some text in the input, the "keyup" event won't be trigger. This patch replaces the "keyup" event with the "change", which works as we want here. The issues: 1/ Search for "wanted" (admin/preferences.pl?op=search&searchfield=wanted) Empty the input, click save Type something and remove it You are able to save, but nothing has changed 2/ Put something in your selection buffer and use the middle click to paste it in the input. No change detected. Test plan: Confirm the issues are fixed and you don't find any regression Note that now the "(modified)" string is displayed when the input loses the focus. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patch pushed to master. Thanks Jonathan! Pushed to 3.18.x will be in 3.18.7 |