Summary: | The ordernumber is not displayed on the basket page | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Acquisitions | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | gmcharlt, nengard, sandboxes |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | acqui/basket.pl | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 11579: Show ordernumber in basket.pl tables
Bug 11056: Delete dead code in basketgroup.pl Bug 11579: Show ordernumber in basket.pl tables [PASSED QA] Bug 11579: Show ordernumber in basket.pl tables |
Description
Jonathan Druart
2014-01-17 14:52:48 UTC
Created attachment 24509 [details] [review] Bug 11579: Show ordernumber in basket.pl tables Test plan: Verify the ordernumber is correctly displayed on the basket page (acqui/basket.pl?basketno=X) Patch tested with a sandbox, by silvere <silvere.hanguehard@enc.sorbonne.fr> Created attachment 24651 [details] [review] Bug 11056: Delete dead code in basketgroup.pl In basketgroup.pl, some code is supposed to be executed if $op = "validate". But this value is no longer assigned to the $op variable since 2009. This patch suppressed dead code, along with parseinputbaskets and parseinputbasketgroups subs, which are obsolete. No functional changes expected Regression test : * Check basketgroup are shown as before the patch, and can be closed and reopened. * Check you can add or remove a basket from a basketgroup, and change information about it (like delivery place) * Check you can create a basketgroup when you close a basket. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> The following commands return nothing: - grep validate acqui/basketgroup.tt - grep -R basketgroup.pl -C 2 | grep validate - git grep parseinputbaskets - git grep parseinputbasketgroups - git grep basketgroup.pl | grep validate Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: silvere <silvere.hanguehard@enc.sorbonne.fr> Created attachment 24652 [details] [review] Bug 11579: Show ordernumber in basket.pl tables Test plan: Verify the ordernumber is correctly displayed on the basket page (acqui/basket.pl?basketno=X) Signed-off-by: silvere <silvere.hanguehard@enc.sorbonne.fr> Sylvère has tested the patch in a sandbox but he applied it yesterday and signed off it today. Meanwhile the sandbox has been reset to master, so the master HEAD has been uploaded. Created attachment 24726 [details] [review] [PASSED QA] Bug 11579: Show ordernumber in basket.pl tables Test plan: Verify the ordernumber is correctly displayed on the basket page (acqui/basket.pl?basketno=X) Signed-off-by: silvere <silvere.hanguehard@enc.sorbonne.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixed a tiny typo in the HTML: </th> > </td>. Passes all tests and QA script. Tested that the ordernumber is now displayed and table sorting works for the smaller and more detailed table. Pushed to master. Thanks, Julian! |