Summary: | Novelist Select in Staff Client | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Templates | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | amy, george, katrin.fischer, kholt, kyle, nick, nicole |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 6902 | ||
Bug Blocks: | 19882 | ||
Attachments: |
Bug 11606 - Add nvelist client to staff
Bug 11606: Add Novelist client to staff Bug 11606: (followup) minor typos Bug 11606: Add Novelist client to staff Bug 11606: (followup) minor typos [PASSED QA] Bug 11606: Add Novelist client to staff [PASSED QA] Bug 11606: (followup) minor typos |
Description
Nicole C. Engard
2014-01-24 13:52:23 UTC
Work to be done: 1) Add new system preferences: a) NovelistSelectStaffEnabled b) NovelistSelectStaffProfile c) NovelistSelectStaffPassword 2) Modify catalogue/detail.pl ( when NovelistSelectStaffEnabled is enabled ) to a) Include https://imageserver.ebscohost.com/novelistselect/ns2init.js b) Create a new tab titled "Novelist Select" in the list of tabs c) Populate the div connected to this tab with the html needed for ns2init.js to function correctly d) Call novSelect.loadContentForQuery using the jQuery method $().ready to trigger the call as soon as that part of the DOM is loaded. 3) Update the Koha OPAC code to use loadContentForQuery rather than the deprecated loadContentForISBN Created attachment 51966 [details] [review] Bug 11606 - Add nvelist client to staff To test: 1 - Apply patches 2 - Update database 3 - View detail pages for some records and ensure no changes have been made 4 - Enable NovelistSelectStaffEnabled (and enter or have info in the Profile and password) 5 - Set NovelistSelectStaffView to 'above' 6 - View detail pages for some records, verify that if novelist info is available it is displyaed and nothign is displayed if not 7 - Repeat with all staff view options Sponsored by: Walla Walla Public Library (http://www.wallawallapubliclibrary.org/) Los Gatos Library (http://www.losgatosca.gov/42/Los-Gatos-Library) Created attachment 52386 [details] [review] Bug 11606: Add Novelist client to staff To test: 1 - Apply patches 2 - Update database 3 - View detail pages for some records and ensure no changes have been made 4 - Enable NovelistSelectStaffEnabled (and enter or have info in the Profile and password) 5 - Set NovelistSelectStaffView to 'above' 6 - View detail pages for some records, verify that if novelist info is available it is displyaed and nothign is displayed if not 7 - Repeat with all staff view options Sponsored by: Walla Walla Public Library (http://www.wallawallapubliclibrary.org/) Los Gatos Library (http://www.losgatosca.gov/42/Los-Gatos-Library) Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> Internal signoff. Created attachment 52387 [details] [review] Bug 11606: (followup) minor typos Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> Internal signoff. Created attachment 52392 [details] [review] Bug 11606: Add Novelist client to staff To test: 1 - Apply patches 2 - Update database 3 - View detail pages for some records and ensure no changes have been made 4 - Enable NovelistSelectStaffEnabled (and enter or have info in the Profile and password) 5 - Set NovelistSelectStaffView to 'above' 6 - View detail pages for some records, verify that if novelist info is available it is displyaed and nothign is displayed if not 7 - Repeat with all staff view options Sponsored by: Walla Walla Public Library (http://www.wallawallapubliclibrary.org/) Los Gatos Library (http://www.losgatosca.gov/42/Los-Gatos-Library) Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> Internal signoff. Signed-off-by: Alexis Rodegerdts <arodegerdts@wallawallawa.gov> Signed-off-by: Dwayne Nance <dnance@ebsco.com> Created attachment 52393 [details] [review] Bug 11606: (followup) minor typos Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> Internal signoff. Signed-off-by: Alexis Rodegerdts <arodegerdts@wallawallawa.gov> Signed-off-by: Dwayne Nance <dnance@ebsco.com> Applies cleanly, passes QA script, doesn't appear to break the detail view, has a lot of sign-offs. I can't confirm the actual functionality as I don't have the needed account information from Novelist, but I am going to pass this on the ground of 'doesn't seem to break things'. It could be nice if one of the testers could confirm it still works ok once its pushed to master. Created attachment 53416 [details] [review] [PASSED QA] Bug 11606: Add Novelist client to staff To test: 1 - Apply patches 2 - Update database 3 - View detail pages for some records and ensure no changes have been made 4 - Enable NovelistSelectStaffEnabled (and enter or have info in the Profile and password) 5 - Set NovelistSelectStaffView to 'above' 6 - View detail pages for some records, verify that if novelist info is available it is displyaed and nothign is displayed if not 7 - Repeat with all staff view options Sponsored by: Walla Walla Public Library (http://www.wallawallapubliclibrary.org/) Los Gatos Library (http://www.losgatosca.gov/42/Los-Gatos-Library) Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> Internal signoff. Signed-off-by: Alexis Rodegerdts <arodegerdts@wallawallawa.gov> Signed-off-by: Dwayne Nance <dnance@ebsco.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 53417 [details] [review] [PASSED QA] Bug 11606: (followup) minor typos Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> Internal signoff. Signed-off-by: Alexis Rodegerdts <arodegerdts@wallawallawa.gov> Signed-off-by: Dwayne Nance <dnance@ebsco.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 16.11, thanks Nick, Jesse! |