Bug 11726

Summary: Untranslatable loading page overlay in offline circ
Product: Koha Reporter: paxed <pasi.kallinen>
Component: I18N/L10NAssignee: Bernardo Gonzalez Kriegel <bgkriegel>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: bgkriegel, f.demians, jonathan.druart, katrin.fischer
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 11726 - Untranslatable loading page overlay in offline circ

Description paxed 2014-02-10 07:28:48 UTC
The following text in circ/offline.tt is not picked up for translation:

$(".loading-overlay div").text(_("Loading page " + page + ", please wait..."));
Comment 1 Bernardo Gonzalez Kriegel 2014-04-03 01:16:56 UTC
Created attachment 26775 [details] [review]
Bug 11726 - Untranslatable loading page overlay in offline circ

This patch reformats a message to be catched by translation script.

To test:
1) Grep for the offending string
egrep -Rn "Loading page |\", please wait" *

only occurrence on koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt

2) Apply the patch

3) Update your preferred language, ej. fi-FI
(cd misc/translator; perl translate update fi-FI)

4) Repeat 1), there are 2 new strings on staff po
file, out of context :), but now can be translated
Comment 2 Jonathan Druart 2014-05-22 14:26:59 UTC
Maybe you could use a placeholder. Something like
$(".loading-overlay div").text(_("Loading page %s, please wait...").format(page));
Comment 3 Bernardo Gonzalez Kriegel 2014-05-22 17:51:31 UTC
Fixed on Bug 12138