Summary: | Use validation plugin when uploading local cover images | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Tools | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/tools/upload-cover-image.pl | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 11785 - Use validation plugin when uploading local cover images
Bug 11785 - Use validation plugin when uploading local cover images Bug 11785 - Use validation plugin when uploading local cover images |
Description
Owen Leonard
2014-02-18 17:13:13 UTC
Created attachment 25389 [details] [review] Bug 11785 - Use validation plugin when uploading local cover images When uploading local cover images the form should not be submitted if no file has been selected. The existing form validation script doesn't work. This patch adds HTML5 validation attributes and use of Koha's built-in form validation plugin. To test, apply the patch and go to Tools -> Upload local cover image. Try to submit the form without selecting a file to upload. You should be prevented from doing so. Choose a file and confirm that the upload completes correctly. Created attachment 25405 [details] [review] Bug 11785 - Use validation plugin when uploading local cover images When uploading local cover images the form should not be submitted if no file has been selected. The existing form validation script doesn't work. This patch adds HTML5 validation attributes and use of Koha's built-in form validation plugin. To test, apply the patch and go to Tools -> Upload local cover image. Try to submit the form without selecting a file to upload. You should be prevented from doing so. Choose a file and confirm that the upload completes correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 25480 [details] [review] Bug 11785 - Use validation plugin when uploading local cover images When uploading local cover images the form should not be submitted if no file has been selected. The existing form validation script doesn't work. This patch adds HTML5 validation attributes and use of Koha's built-in form validation plugin. To test, apply the patch and go to Tools -> Upload local cover image. Try to submit the form without selecting a file to upload. You should be prevented from doing so. Choose a file and confirm that the upload completes correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Pushed to master. Thanks, Owen! Pushed to 3.14.x, will be in 3.14.07 Pushed to 3.12.x will be in 3.12.13 |