Bug 11928

Summary: table aqorderdelivery seem useless
Product: Koha Reporter: Zeno Tajoli <ztajoli>
Component: DatabaseAssignee: Mark Tompsett <mtompset>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: fridolin.somers, gmcharlt, mtompset
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: Sponsored Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 11928 - Remove unused table
Bug 11928 - Remove unused table
Bug 11928 - Remove unused table aqorderdelivery
Bug 11928 - Remove unused table aqorderdelivery

Description Zeno Tajoli 2014-03-12 12:54:39 UTC
Hi to all,

it seem that the table 'aqorderdelivery' is not used in Koha now.
No bugs if I search with 'aqorderdelivery'.
If I search in the code the result is:

koha@lctest:~/master$ grep -r -i 'aqorderdelivery' * 
installer/data/mysql/kohastructure.sql:-- Table structure for table `aqorderdelivery`
installer/data/mysql/kohastructure.sql:DROP TABLE IF EXISTS `aqorderdelivery`;
installer/data/mysql/kohastructure.sql:CREATE TABLE `aqorderdelivery` (
installer/data/mysql/update22to30.pl:           aqorderdelivery => [
INSTALL.fedora7:| aqorderdelivery |
Koha/Schema/Result/Aqorderdelivery.pm:package Koha::Schema::Result::Aqorderdelivery;
Koha/Schema/Result/Aqorderdelivery.pm:Koha::Schema::Result::Aqorderdelivery
Koha/Schema/Result/Aqorderdelivery.pm:=head1 TABLE: C<aqorderdelivery>
Koha/Schema/Result/Aqorderdelivery.pm:__PACKAGE__->table("aqorderdelivery");

so no used.
The table seems inserted in 2009 but never used.
I think it could be deleted.
Comment 1 Mark Tompsett 2014-03-12 15:58:08 UTC Comment hidden (obsolete)
Comment 2 Mark Tompsett 2014-03-12 16:05:50 UTC Comment hidden (obsolete)
Comment 3 Mark Tompsett 2014-03-12 16:07:10 UTC
I agree that it is unused, and here is a patch to remove it. I decided against modifying update22to30.pl, so as to maintain continuity of upgrade paths taken by others in the past.
Comment 4 Galen Charlton 2014-03-12 18:38:42 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2014-03-13 10:17:44 UTC
Created attachment 26240 [details] [review]
Bug 11928 - Remove unused table aqorderdelivery

Aqorderdelivery has apparently never been used. This patch
removes it.

TEST PLAN
---------
1) Apply patch.
2) Run the Koha QA Test tool.
3) Confirm table is there.
4) Run upgrade process.
5) Confirm table has been removed.
6) Drop koha database and create empty one.
7) Fresh install from staff client.
8) Confirm table was not created.
9) I'm unsure how to test the Schema's. It was just git rm'd.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 6 Galen Charlton 2014-03-13 15:32:15 UTC
Pushed to master.  Thanks, Mark!
Comment 7 Fridolin Somers 2014-06-12 07:35:51 UTC
This is a cleanup, not really useful for stable branches.
I set as resolved.