Bug 12337

Summary: Multi-clicking the renewal buttons on circulation.pl can trigger "renewal failed" message.
Product: Koha Reporter: Kyle M Hall <kyle>
Component: CirculationAssignee: Kyle M Hall <kyle>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: gmcharlt, kyle.m.hall, sandboxes, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 12337 - Multi-clicking the renewal buttons on circulation.pl can trigger "renewal failed" message.
Bug 12337 - Multi-clicking the renewal buttons on circulation.pl can trigger "renewal failed" message.
Bug 12337 - Multi-clicking the renewal buttons on circulation.pl can trigger "renewal failed" message.

Description Kyle M Hall 2014-05-30 11:17:08 UTC
Each time the "renew all" or "renew or return" buttons are click, the renewal process is triggered. If the patron only has one renewal left, and the button is multi-clicked, the librarian may receive a "renewal failed" message even though the renewal did occur. In addition, this can just unwanted multiple consecutive renewals as well.
Comment 1 Kyle M Hall 2014-05-30 11:19:44 UTC Comment hidden (obsolete)
Comment 2 Biblibre Sandboxes 2014-06-04 22:06:49 UTC
Patch tested with a sandbox, by Nick Clemens <nick@quecheelibrary.org>
Comment 3 Biblibre Sandboxes 2014-06-04 22:07:05 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2014-06-06 14:31:33 UTC
Created attachment 28709 [details] [review]
Bug 12337 - Multi-clicking the renewal buttons on circulation.pl can trigger "renewal failed" message.

Each time the "renew all" or "renew or return" buttons are click, the
renewal process is triggered. If the patron only has one renewal left,
and the button is multi-clicked, the librarian may receive a
"renewal failed" message even though the renewal did occur. In
addition, this can just unwanted multiple consecutive renewals
as well.

Test Plan:
1) Check out an item to a patron that can have 1 renewal
2) Click the "renew all" button multiple times, fast and furiously
3) Note the "renewal failed" messaged
4) Apply this patch
5) Repeat steps 1 and 2
6) Note the item is now renewed without the failure message

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 5 Tomás Cohen Arazi 2014-07-02 18:11:20 UTC
Patch pushed to master.

Thanks Kyle!