Bug 12452

Summary: Check subscription expiration doesn't work
Product: Koha Reporter: Koha Team University Lyon 3 <koha>
Component: SerialsAssignee: Bugs List <koha-bugs>
Status: RESOLVED DUPLICATE QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: colin.campbell, jonathan.druart, katrin.fischer, marjorie.barry-vila, paola.rossi
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:

Description Koha Team University Lyon 3 2014-06-19 12:24:05 UTC
May be I missed something but it's impossible to get any results in the subscriptions check expiration page even if there are expired subscriptions in the database.

Olivier Crouzet
Comment 1 Katrin Fischer 2015-01-30 07:10:55 UTC
I can see the problem on current master.
Comment 2 Jonathan Druart 2015-01-30 08:24:15 UTC
(In reply to Katrin Fischer from bug 8436 comment #13)
> Julian, could you take a look at the search for the expiration date? I think
> I can see bug 12452. 
> 
> I have a serial subscription with expiration date on 10/09/2014.
> If I use the filter on the left side of the subscription search with
> 01/10/2014 the subscription shows up (as it should).
> 
> But when I repeat the same search on the 'check expiration' page, the
> subscription is not found.
> 
> Using iso formatted dates dd/mm/yyyy.

Looks good here.

- formatdate is dd/mm/yyyy

- MariaDB [koha]> select enddate from subscription where subscriptionid=6\G
*************************** 1. row ***************************
enddate: 2016-07-01

- go on serials/checkexpiration.pl

- Expiring before: 01/08/2016

I got "1 subscription(s) will expire before 01/08/2016"

What I did wrong?
Comment 3 Jonathan Druart 2015-01-30 09:02:19 UTC
subscriptions.enddate is not checked if frequency, unit, etc. exist.
Comment 4 Paola Rossi 2015-01-30 10:29:28 UTC
The bug 6968 #c0's error :
"The page Check Expiration the in Serials section show items that
are going to expire before [strictly <] the date selected, but
doesn't show items that expired before [<=] today"
is consistent with the Katrin's 10/09/2014 case (run in 2015) and
the 2016-07-01 case, in comment #2.

I recently saw that 6968 error on master 3.19.00.006 head 13526.

Perhaps the 6968's error and the error in comment #3 might be in overlapping.
Comment 5 Jonathan Druart 2019-12-12 10:16:33 UTC
I do not understand this bug report so I am suggesting to move to the new bug 23243. It would be helpful to get the patch tested there.

*** This bug has been marked as a duplicate of bug 23243 ***