Bug 12610

Summary: Replace use of DBI in C4::Tags with DBIx::Class
Product: Koha Reporter: Kyle M Hall <kyle>
Component: Architecture, internals, and plumbingAssignee: Galen Charlton <gmcharlt>
Status: CLOSED WONTFIX QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: jonathan.druart
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 12608    
Attachments: Bug 12610 - Replace use of DBI in C4::Tags with DBIx::Class
Bug 12610 - Replace use of DBI in C4::Tags with DBIx::Class
Bug 12610 - Replace use of DBI in C4::Tags with DBIx::Class
Bug 12610 - Replace use of DBI in C4::Tags with DBIx::Class

Description Kyle M Hall 2014-07-18 16:38:00 UTC
We should replace the use of DBI in C4::Tags with DBIC instead.
Comment 1 Kyle M Hall 2014-07-18 16:39:17 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2014-07-18 16:46:09 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2014-07-18 16:51:06 UTC Comment hidden (obsolete)
Comment 4 Kyle M Hall 2014-07-18 17:05:01 UTC
Created attachment 29863 [details] [review]
Bug 12610 - Replace use of DBI in C4::Tags with DBIx::Class

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Tags.t
3) Note all unit tests pass
Comment 5 Jonathan Druart 2014-08-29 14:05:43 UTC
(In reply to Kyle M Hall from comment #4)

> 3) Note all unit tests pass

It would have work if t/db_dependent/Tags.t covered all subroutines from C4::Tags.
It is not the case at all, only stratify_tags is covered.
Would it be possible to add some unit tests to this file to prove all your changes don't introduce regression?
Comment 6 Kyle M Hall 2016-08-23 16:44:11 UTC
I don't have time to continue working on this patch.