Bug 12929

Summary: bug 12716 introduces a regression on the patron import tools
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: ToolsAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: kyle, nengard, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 12716, 12859    
Bug Blocks:    
Attachments: Bug 12929: Restore behavior before bug 12716
[SIGNED-OFF] Bug 12929: Restore behavior before bug 12716
Bug 12929 [QA Followup] - Hide borrownumber from sample csv file
Bug 12929 [QA Followup] - Hide borrownumber from sample csv file
[PASSED QA] Bug 12929: Restore behavior before bug 12716
[PASSED QA] Bug 12929 [QA Followup] - Hide borrownumber from sample csv file
Bug 12929 [QA Followup] - Hide borrownumber from sample csv file

Description Jonathan Druart 2014-09-16 14:06:05 UTC
Bug 12716 removes too many lines.
See bug 12859 for the history.
Comment 1 Jonathan Druart 2014-09-16 14:30:05 UTC Comment hidden (obsolete)
Comment 2 Petter Goksøyr Åsen 2014-10-02 08:12:19 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2014-10-05 22:48:23 UTC
Kyle, the patch applies correctly here.
Switch the status back to SO.
Comment 4 Kyle M Hall 2014-10-10 12:20:44 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2014-10-10 13:52:21 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2014-10-11 21:52:17 UTC
Created attachment 32279 [details] [review]
[PASSED QA] Bug 12929: Restore behavior before bug 12716

This patch remove borrowernumber from the borrower list fields and
display the field list in the notes.

Test plan:
- verify that the list of fields is displayed on the right (Notes).
- verify the borrowernumber is not displayed anymore in the field list.

Signed-off-by: Petter Goksoyr Asen <boutrosboutrosboutros@gmail.com>

Confirmed that this patch removes borrowernumber from list of default
values, and reintroduces missing list of CSV columns in the Notes field.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Katrin Fischer 2014-10-11 21:52:34 UTC
Created attachment 32280 [details] [review]
[PASSED QA] Bug 12929 [QA Followup] - Hide borrownumber from sample csv file

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Works as described, hides the borrowernumber from the list
of fields to edit and also brings back the list of fields
for the sample file in the documentation.

Passes tests and QA script.
Comment 8 Tomás Cohen Arazi 2014-10-14 14:26:13 UTC
Patches pushed to master.

Thanks Jonathan and Kyle.
Comment 9 Katrin Fischer 2014-10-15 14:40:52 UTC
Created attachment 32335 [details] [review]
Bug 12929 [QA Followup] - Hide borrownumber from sample csv file

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Works as described, hides the borrowernumber from the list
of fields to edit and also brings back the list of fields
for the sample file in the documentation.

Passes tests and QA script.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>