Bug 13199

Summary: Incoherence between 'en' sample notices and translated notices
Product: Koha Reporter: Frédéric Demians <f.demians>
Component: Installation and upgrade (web-based installer)Assignee: Frédéric Demians <f.demians>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: bgkriegel, gmcharlt, katrin.fischer, mtompset, tomascohen, ztajoli
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 13199 Add missing notices for fr-FR installation
Bug 13199 Test incoherence between 'en' sample notices and translated notices
Bug 13199 Add missing notices for several installations
[SIGNED-OFF] Bug 13199: Test incoherence between 'en' sample notices and translated notices
[SIGNED-OFF] Bug 13199: Add missing notices for several installations
Bug 13199: follow up to fix Licence and some koha-qa errors
[PASSED QA] Bug 13199: Test incoherence between 'en' sample notices and translated notices
[PASSED QA] Bug 13199: Add missing notices for several installations
[PASSED QA] Bug 13199: follow up to fix Licence and some koha-qa errors

Description Frédéric Demians 2014-11-04 19:44:27 UTC
Koha sample notices are loaded to 'letter' table from a text SQL file
during Koha installation by web installer. The reference file is the one
provided for English (en) installation :

  <koha_root>/installer/data/mysql/en/mandatory/sample_notices.sql

Alternatives files are provided for other languages. Those files are difficult
to keep synchronized with reference file. This could be an functional issue
since some Koha operation depend on notice existence, for example Print Slip in
Circulation.

For example, for French installation, those notices are missing: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP
Comment 1 Frédéric Demians 2014-11-04 20:21:37 UTC Comment hidden (obsolete)
Comment 2 Frédéric Demians 2014-11-04 20:22:12 UTC Comment hidden (obsolete)
Comment 3 Frédéric Demians 2014-11-04 20:25:01 UTC
The test identifies other missing notices:

- it-IT/necessari/notices.sql: OPAC_REG_VERIFY, RENEWAL
- pl-PL/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY,
  RESERVESLIP, TRANSFERSLIP
- ru-RU/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY,
  RESERVESLIP, TRANSFERSLIP
- uk-UA/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY,
  RESERVESLIP, TRANSFERSLIP
Comment 4 Frédéric Demians 2014-11-05 07:23:59 UTC
Katrin: I've added you to this patch CC! You're in best position to confirm this bug may be disturbing/blocking for non-English installations, since you're the only one to succeed having a de-DE on a par with 'en' sample notices.
Comment 5 Katrin Fischer 2014-11-05 23:04:59 UTC
Hi Frederic, 

hopefully those will be the last inconsistencies to be cleaned up. I'd like to have the test, but it will need to pass. - Could you also provide a patch for ru-RU and uk-UA? Copying the English samples is fine - still a good help to get people started making their own translated notices.
Comment 6 Frédéric Demians 2014-11-06 06:44:35 UTC
> Could you also provide a patch
> for ru-RU and uk-UA? Copying the English samples is fine - still a good help
> to get people started making their own translated notices.

Ok. Will do this evening. Do you have someone doing it-I & pl-PL?
Comment 7 Katrin Fischer 2014-11-06 06:46:08 UTC
Ah sorry, I missed those in the test output. If you could do them all that would be great.
Comment 8 Zeno Tajoli 2014-11-06 10:52:32 UTC
For OPAC_REG_VERIFY, RENEWAL in it-IT/necessari/notices.sql the English strings are OK
Comment 9 Frédéric Demians 2014-11-06 18:54:25 UTC Comment hidden (obsolete)
Comment 10 Bernardo Gonzalez Kriegel 2014-11-07 00:52:21 UTC Comment hidden (obsolete)
Comment 11 Bernardo Gonzalez Kriegel 2014-11-07 00:52:33 UTC Comment hidden (obsolete)
Comment 12 Bernardo Gonzalez Kriegel 2014-11-07 00:53:14 UTC Comment hidden (obsolete)
Comment 13 Katrin Fischer 2014-11-07 07:02:49 UTC
Created attachment 33359 [details] [review]
[PASSED QA] Bug 13199: Test incoherence between 'en' sample notices and translated notices

This test identifies incoherences between translated sample notices and the
'en' reference file.

Koha sample notices are loaded to 'letter' table from a text SQL file
during Koha installation by web installer. The reference file is the one
provided for English (en) installation :

  <koha_root>/installer/data/mysql/en/mandatory/sample_notices.sql

Alternatives files are provided for other languages. Those files are difficult
to keep synchronized with reference file. This could be an functional issue
since some Koha operation depend on notice existence, for example Print Slip in
Circulation.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Test works and identify missing notices
A few koha-qa errors fixed in followup

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 14 Katrin Fischer 2014-11-07 07:02:53 UTC
Created attachment 33360 [details] [review]
[PASSED QA] Bug 13199: Add missing notices for several installations

prove xt/sample_notices.sql identifies missing notices.  This patch add those
missing notices:

- fr-FR ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP
- it-IT/necessari/notices.sql: OPAC_REG_VERIFY, RENEWAL
- pl-PL/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY,
  RESERVESLIP, TRANSFERSLIP
- ru-RU/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY,
  RESERVESLIP, TRANSFERSLIP
- uk-UA/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY,
  RESERVESLIP, TRANSFERSLIP

TO TEST:

(1) Without this patch, but with the patch adding xt/sample_notices.sql:
    prove xt/sample_notices.sql list all the above missing notices.
(2) Apply this patch. And do prove again: nothing is reported.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Work as described, test stop failing
No koha-qa errors

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 15 Katrin Fischer 2014-11-07 07:02:56 UTC
Created attachment 33361 [details] [review]
[PASSED QA] Bug 13199: follow up to fix Licence and some koha-qa errors

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 16 Katrin Fischer 2014-11-07 07:06:43 UTC
Thx Frederic and Bernardo!
Comment 17 Tomás Cohen Arazi 2014-11-20 12:52:16 UTC
Patches pushed to master.

Thanks Frederic and Bernardo!
Comment 18 Mark Tompsett 2019-07-10 18:50:19 UTC
*** Bug 13808 has been marked as a duplicate of this bug. ***