Bug 13369

Summary: [Datatables] tr and td are not correctly highlighted
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: TemplatesAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: chris, mtj, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 13371, 13380    
Attachments: without the patch
with the patch
Bug 13369: table should been highlighted correctly when row are grouped
[SIGNED-OFF] Bug 13369: table should been highlighted correctly when row are grouped
[SIGNED OFF] Bug 13369: table should been highlighted correctly when row are grouped
[PASSED QA] Bug 13369: table should been highlighted correctly when row are grouped

Description Jonathan Druart 2014-12-02 09:47:08 UTC
On the fund list, the color line highlighting is not done correctly, see the screenshot.
Comment 1 Jonathan Druart 2014-12-02 09:50:32 UTC
Created attachment 34052 [details]
without the patch
Comment 2 Jonathan Druart 2014-12-02 09:50:56 UTC
Created attachment 34053 [details]
with the patch
Comment 3 Jonathan Druart 2014-12-02 09:53:32 UTC Comment hidden (obsolete)
Comment 4 Owen Leonard 2014-12-02 13:48:57 UTC Comment hidden (obsolete)
Comment 5 Tomás Cohen Arazi 2014-12-02 23:25:35 UTC Comment hidden (obsolete)
Comment 6 Kyle M Hall 2014-12-05 15:02:57 UTC
Created attachment 34147 [details] [review]
[PASSED QA] Bug 13369: table should been highlighted correctly when row are grouped

The css used to highlight the rows comes from staff-global.css
We need a more specific rule to be used.

Test plan:
Go on the fund list view and confirm that the rows are correctly
highlighted.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 7 Tomás Cohen Arazi 2015-01-10 19:18:34 UTC
Patch pushed to master.

Thanks Jonathan!
Comment 8 Chris Cormack 2015-01-12 00:13:38 UTC
Pushed to 3.18.x will be in 3.18.3
Comment 9 Mason James 2015-01-16 23:29:54 UTC
Pushed to 3.16.x, will be in 3.16.7