Summary: | Inputs overflow in filters | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Templates | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 12376 | ||
Bug Blocks: | 13371 | ||
Attachments: |
Bug 13370: Inputs overflow in filter
Bug 13370: Inputs overflow in filter [SIGNED-OFF] Bug 13370: Inputs overflow in filter [PASSED QA] Bug 13370: Inputs overflow in filter |
Description
Jonathan Druart
2014-12-02 10:36:27 UTC
Created attachment 34056 [details] [review] Bug 13370: Inputs overflow in filter Bug 12376 adds some padding to inputs. This cause an overflow on the record detail page. Test plan: 1/ Go on a record detail page with items 2/ Enable filters Without the patch, the inputs overflow, with the patch it should be corrected (as before bug 12376). This doesn't apply, but I'm not sure why. The patch refers to this supposedly existing line: span.filter_column > input.date_range_filter { ..which in master is span.filter_column > input.text_filter { I can't tell if this is intended to be dependent on another patch or if the difference is unintentional. Looks good here... Bug 13370 - Inputs overflow in filters 34056 - Bug 13370: Inputs overflow in filter Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 13370: Inputs overflow in filter Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/css/datatables.css Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/css/datatables.css Created attachment 34067 [details] [review] Bug 13370: Inputs overflow in filter Bug 12376 adds some padding to inputs. This cause an overflow on the record detail page. Test plan: 1/ Go on a record detail page with items 2/ Enable filters Without the patch, the inputs overflow, with the patch it should be corrected (as before bug 12376). Ok, should be better now. Created attachment 34068 [details] [review] [SIGNED-OFF] Bug 13370: Inputs overflow in filter Bug 12376 adds some padding to inputs. This cause an overflow on the record detail page. Test plan: 1/ Go on a record detail page with items 2/ Enable filters Without the patch, the inputs overflow, with the patch it should be corrected (as before bug 12376). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 34145 [details] [review] [PASSED QA] Bug 13370: Inputs overflow in filter Bug 12376 adds some padding to inputs. This cause an overflow on the record detail page. Test plan: 1/ Go on a record detail page with items 2/ Enable filters Without the patch, the inputs overflow, with the patch it should be corrected (as before bug 12376). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch pushed to master. Thanks Jonathan! Pushed to 3.18.x will be in 3.18.3 |