Summary: | XSLT and OpacItemLocation sys pref | ||
---|---|---|---|
Product: | Koha | Reporter: | Ed Veal <eveal> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED WORKSFORME | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | bgkriegel, katrin.fischer |
Version: | 3.16 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
[SIGNED-OFF] Bug 13948: Add ability to dump template toolkit variables to html comment
[SIGNED-OFF] Bug 13948 [QA Followup] - Make dependency optional [SIGNED-OFF] Bug 13948: Prevent explosion when Template::Plugin::Stash not installed |
Description
Ed Veal
2015-03-16 17:31:15 UTC
Created attachment 39242 [details] [review] [SIGNED-OFF] Bug 13948: Add ability to dump template toolkit variables to html comment It would be incredibly helpful if we could easily enable Koha to dump all Template Toolkit variables to a comment for debugging purposes. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Enable the new system preferences DumpTemplateVarsIntranet and DumpTemplateVarsOpac 4) Load a page in the staff intranet, view the html source 5) Note the template toolkit variables are embedded in an html comment 6) Load a page in the opac, view the html source 7) Note the template toolkit variable are embedded in an html comment NOTE: I had to cpan2deb Template::Plugin::Stash to test. This is not optimal. Additionally: http://www.template-toolkit.org/docs/modules/Template/Plugin/index.html does not contain Stash. I suspect this was how it was introduced initially by TT. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Created attachment 39243 [details] [review] [SIGNED-OFF] Bug 13948 [QA Followup] - Make dependency optional Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Created attachment 39244 [details] [review] [SIGNED-OFF] Bug 13948: Prevent explosion when Template::Plugin::Stash not installed TEST PLAN --------- 1) Install first two patches 2) do not install, or uninstall Template::Plugin::Stash 3) Upgrade to make sure system preference is added. 4) Set the system preference to turn it on for Staff and OPAC 5) Refresh staff -- kaboom 6) Load OPAC -- kaboom 7) Apply this patch 8) Reload staff and OPAC -- nice HTML comment about what is wrong. 9) run koha qa test tools. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Neat, runs well. Tested with/without sysprefs and Template::Plugin::Stash No koha-qa errors Sorry, wrong bug :( If I understand the description of the problem correctly, this is not valid in master. Ed can you please check? |