Description
Aleisha Amohia
2015-08-05 04:13:33 UTC
Created attachment 46956 [details] [review] 14647 - Make the file name extension dynamic on exporting records Test - 1. Go to /cgi-bin/koha/tools/export.pl and locate the Output format form 2. Change the file format from dropdown and notice the change in the 'File name' 3. Type a random name into ' Created attachment 46963 [details] [review] 14647 - Make the file name extension dynamic on exporting records Test - 1. go to cgi-bin/koha/tools/export.pl 2. Check that both tabs ("Export bibliographic records & Rxport authority records") do the following 3. In Output format 4. When changing "File format" from dropdown it update "file name" 5. Still works with user inputted names Created attachment 47047 [details] [review] 14647 - Make the file name extension dynamic on exporting records Test - 1. go to cgi-bin/koha/tools/export.pl 2. Check that both tabs ("Export bibliographic records & Rxport authority records") do the following 3. In Output format 4. When changing "File format" from dropdown it update "file name" 5. Still works with user inputted names Created attachment 47048 [details] [review] 14647 - Make the file name extension dynamic on exporting records Test - 1. go to cgi-bin/koha/tools/export.pl 2. Check that both tabs ("Export bibliographic records & Rxport authority records") do the following 3. In Output format 4. When changing "File format" from dropdown it update "file name" 5. Still works with user inputted names Have tested and this works perfectly! Can someone else please sign off :) Created attachment 47275 [details] [review] 14647 - Make the file name extension dynamic on exporting records Test - 1. go to cgi-bin/koha/tools/export.pl 2. Check that both tabs ("Export bibliographic records & Rxport authority records") do the following 3. In Output format 4. When changing "File format" from dropdown it update "file name" 5. Still works with user inputted names Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> It does not work: you are modifying a param in the template, but not in the script (output_format_auth). When I export authorities, I always get an empty file named "koha.mrc". Created attachment 64943 [details] [review] Bug 14647: [FOLLOW-UP] Changes to script This patch adds the necessary changes to the script so that the filename extensions works for exporting authorities. To test: 1) Attempt to export with all filetypes for biblios and authorities 2) Confirm the extension for the exported file (after clicking the Export button) is correct for each one Sponsored-by: Catalyst IT Patch doesn't apply, please rebase! Created attachment 98541 [details] [review] Bug 14647: Make the file name extension dynamic on exporting records Test - 1. go to cgi-bin/koha/tools/export.pl 2. Check that both tabs ("Export bibliographic records & Rxport authority records") do the following 3. In Output format 4. When changing "File format" from dropdown it update "file name" 5. Still works with user inputted names Works as expected. Created attachment 98542 [details] [review] Bug 14647: (follow-up) Changes to script This patch adds the necessary changes to the script so that the filename extensions works for exporting authorities. To test: 1) Attempt to export with all filetypes for biblios and authorities 2) Confirm the extension for the exported file (after clicking the Export button) is correct for each one Sponsored-by: Catalyst IT This all works as expected for the file name changes - with the default of marc, and when changing the file name. However, the content when authority records are exported as XML is in MARC format, rather than XML (this works correctly before the patch is applied). Created attachment 98627 [details] [review] Bug 14647: (follow-up) Fix script not detecting XML output format Created attachment 98631 [details] [review] Bug 14647: Make the file name extension dynamic on exporting records Test - 1. go to cgi-bin/koha/tools/export.pl 2. Check that both tabs ("Export bibliographic records & Rxport authority records") do the following 3. In Output format 4. When changing "File format" from dropdown it update "file name" 5. Still works with user inputted names Works as expected. Signed-off-by: David Nind <david@davidnind.com> Created attachment 98632 [details] [review] Bug 14647: (follow-up) Changes to script This patch adds the necessary changes to the script so that the filename extensions works for exporting authorities. To test: 1) Attempt to export with all filetypes for biblios and authorities 2) Confirm the extension for the exported file (after clicking the Export button) is correct for each one Sponsored-by: Catalyst IT Signed-off-by: David Nind <david@davidnind.com> Created attachment 98633 [details] [review] Bug 14647: (follow-up) Fix script not detecting XML output format Signed-off-by: David Nind <david@davidnind.com> Created attachment 99287 [details] [review] Bug 14647: Make the file name extension dynamic on exporting records Test - 1. go to cgi-bin/koha/tools/export.pl 2. Check that both tabs ("Export bibliographic records & Rxport authority records") do the following 3. In Output format 4. When changing "File format" from dropdown it update "file name" 5. Still works with user inputted names Works as expected. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 99288 [details] [review] Bug 14647: (follow-up) Changes to script This patch adds the necessary changes to the script so that the filename extensions works for exporting authorities. To test: 1) Attempt to export with all filetypes for biblios and authorities 2) Confirm the extension for the exported file (after clicking the Export button) is correct for each one Sponsored-by: Catalyst IT Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 99289 [details] [review] Bug 14647: (follow-up) Fix script not detecting XML output format Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 99290 [details] [review] Bug 14647: Make spelling in file format pull downs match While bibliographic had XML and MARC, authorities had xml and marc in the pull down. This just makes both the same. To test: - Look at the pull downs on both tabs and verify they are now using the same spelling Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work everyone! Pushed to master for 20.05 enhancement not backported to 19.11.x |