Summary: | Novelist js throws an error if no ISBN | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | OPAC | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | brendan, f.demians, gwilliams, jdemuth, julian.maurice |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 15210 - Novelist throws an error if no ISBN
Bug 15210 - Novelist throws an error if no ISBN Bug 15210 - Novelist throws an error if no ISBN Bug 15210 - Novelist throws an error if no ISBN |
Description
Nick Clemens (kidclamp)
2015-11-18 16:48:51 UTC
Created attachment 44965 [details] [review] Bug 15210 - Novelist throws an error if no ISBN This patch makes opac-detail.tt check for an ISBN before attempting to load Novelist content and prevents a js error which breaks other code. To test: 1 - Enable novelist 2 - Add a visible change to OPACUserJS eg: $(document).ready(function() {$("body").css("background-color","pink");}); 3 - Load a record with no ISBN 4 - Note you do not see a color change in the body and that there is an error in the console 5 - Apply patch 6 - Reload the record 7 - You should see the color change and no error in the js Created attachment 45787 [details] [review] Bug 15210 - Novelist throws an error if no ISBN This patch makes opac-detail.tt check for an ISBN before attempting to load Novelist content and prevents a js error which breaks other code. To test: 1 - Enable novelist 2 - Add a visible change to OPACUserJS eg: $(document).ready(function() {$("body").css("background-color","pink");}); 3 - Load a record with no ISBN 4 - Note you do not see a color change in the body and that there is an error in the console 5 - Apply patch 6 - Reload the record 7 - You should see the color change and no error in the js Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Created attachment 45802 [details] [review] Bug 15210 - Novelist throws an error if no ISBN This patch makes opac-detail.tt check for an ISBN before attempting to load Novelist content and prevents a js error which breaks other code. To test: 1 - Enable novelist 2 - Add a visible change to OPACUserJS eg: $(document).ready(function() {$("body").css("background-color","pink");}); 3 - Load a record with no ISBN 4 - Note you do not see a color change in the body and that there is an error in the console 5 - Apply patch 6 - Reload the record 7 - You should see the color change and no error in the js Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 46064 [details] [review] Bug 15210 - Novelist throws an error if no ISBN This patch makes opac-detail.tt check for an ISBN before attempting to load Novelist content and prevents a js error which breaks other code. To test: 1 - Enable novelist 2 - Add a visible change to OPACUserJS eg: $(document).ready(function() {$("body").css("background-color","pink");}); 3 - Load a record with no ISBN 4 - Note you do not see a color change in the body and that there is an error in the console 5 - Apply patch 6 - Reload the record 7 - You should see the color change and no error in the js Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> pushed to master - thanks! Patch pushed to 3.22.x, will be in 3.22.2 This patch has been pushed to 3.20.x, will be in 3.20.8. |