Description
Liz Rea
2015-11-19 03:37:28 UTC
Depends on 15211 and 15212 because both of them bring this issue forward. Created attachment 45031 [details] [review] Bug 15213 - Fix tools sidebar to highlight Patron lists when in that module To test: Add some patron lists, navigate through the lists interface and make sure that while you are in the module, that Patron lists is highlighted on the sidebar. Depends on 15211 and 15213 Comment on attachment 45031 [details] [review] Bug 15213 - Fix tools sidebar to highlight Patron lists when in that module Actually I don't want 15223 included in this patch, in case this one doesn't get in, so I'll send a new patch. Created attachment 45033 [details] [review] Bug 15213 - Fix tools sidebar to highlight Patron lists when in that module To test: Add some patron lists, navigate through the lists interface and make sure that while you are in the module, that Patron lists is highlighted on the sidebar. Depends on 15211 and 15213 Hi Liz (In reply to Liz Rea from comment #1) > Depends on 15211 and 15212 because both of them bring this issue forward. 15212 doesn't have patch attached. (In reply to Liz Rea from comment #5) > Created attachment 45033 [details] [review] [review] > Bug 15213 - Fix tools sidebar to highlight Patron lists when in that module > To test: > > Add some patron lists, navigate through the lists interface and make sure > that while you are in the module, that Patron lists is highlighted on the > sidebar. > > Depends on 15211 and 15213 Do I need to apply bug 15211 on top? Test plan isn't clear for me, please reword/clarify the message :) Regards Created attachment 45272 [details] [review] [SIGNED-OFF] Bug 15213 - fix buttons on patron lists To test: go to tools -> patron lists notice that the buttons are not misaligned anymore You may need to force refresh the page to see the original issue, and to see it fixed. http://bugs.koha-community.org/show_bug.cgi?id=15223 Signed-off-by: Owen Leonard <oleonard@myacpl.org> I can reproduce the problem in Chromium and the patch fixes it. No adverse effects in Firefox. Comment on attachment 45272 [details] [review] [SIGNED-OFF] Bug 15213 - fix buttons on patron lists Sorry, wrong bug report! Created attachment 51936 [details] [review] [SIGNED-OFF] Bug 15213 - Fix tools sidebar to highlight Patron lists when in that module To test: Add some patron lists, navigate through the lists interface and make sure that while you are in the module, that Patron lists is highlighted on the sidebar. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Ha I forgot all about this patch. Thanks Owen! Liz Created attachment 52118 [details] [review] Bug 15213 - Fix tools sidebar to highlight Patron lists when in that module To test: Add some patron lists, navigate through the lists interface and make sure that while you are in the module, that Patron lists is highlighted on the sidebar. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended patch: fix alignement Pushed to master for Koha 16.11, thanks Liz! Pushed in 16.05. Will be in 16.05.01. Not needed in 3.22.x |