Summary: | Translatability: fix issue in facets (Availability') | ||
---|---|---|---|
Product: | Koha | Reporter: | Marc Véron <veron> |
Component: | I18N/L10N | Assignee: | Marc Véron <veron> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | brendan, f.demians, hector.hecaxmmx, julian.maurice |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 15345: Translatability: fix issue in facets (Availability')
[SIGNED-OFF]Bug 15345: Translatability: fix issue in facets (Availability') [PASSED QA] Bug 15345: Translatability: fix issue in facets (Availability') Bug 15345: Translatability: fix issue in facets (Availability') |
Description
Marc Véron
2015-12-09 17:35:43 UTC
Created attachment 45555 [details] [review] Bug 15345: Translatability: fix issue in facets (Availability') This patch fixes an issue with a splitted sentence in facets (Avalability) that leads to weird translations e.g.: German: 'Zeige nur Verfügbar Exemplare' French: 'Montrer seulement disponible exemplaires' Additionally, the link "Show all items" gets it's own li tags to display nicely like the other links in the facets column and it removes superfluous dots. To test in OPAC and Staff client: - Apply patch - Do a search that results in more than one available items - In column "Refine your search", click on "Limit to currently available items" - Verify that the message "Showing only available items" and the link "Show all items" display nicely. Created attachment 45557 [details] [review] [SIGNED-OFF]Bug 15345: Translatability: fix issue in facets (Availability') This patch fixes an issue with a splitted sentence in facets (Avalability) that leads to weird translations e.g.: German: 'Zeige nur Verfügbar Exemplare' French: 'Montrer seulement disponible exemplaires' Additionally, the link "Show all items" gets it's own li tags to display nicely like the other links in the facets column and it removes superfluous dots. To test in OPAC and Staff client: - Apply patch - Do a search that results in more than one available items - In column "Refine your search", click on "Limit to currently available items" - Verify that the message "Showing only available items" and the link "Show all items" display nicely. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> use_zebra_facets set to 0 in koha-conf.xml to test. Works as described Created attachment 45624 [details] [review] [PASSED QA] Bug 15345: Translatability: fix issue in facets (Availability') This patch fixes an issue with a splitted sentence in facets (Avalability) that leads to weird translations e.g.: German: 'Zeige nur Verfügbar Exemplare' French: 'Montrer seulement disponible exemplaires' Additionally, the link "Show all items" gets it's own li tags to display nicely like the other links in the facets column and it removes superfluous dots. To test in OPAC and Staff client: - Apply patch - Do a search that results in more than one available items - In column "Refine your search", click on "Limit to currently available items" - Verify that the message "Showing only available items" and the link "Show all items" display nicely. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> use_zebra_facets set to 0 in koha-conf.xml to test. Works as described Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 46028 [details] [review] Bug 15345: Translatability: fix issue in facets (Availability') This patch fixes an issue with a splitted sentence in facets (Avalability) that leads to weird translations e.g.: German: 'Zeige nur Verfügbar Exemplare' French: 'Montrer seulement disponible exemplaires' Additionally, the link "Show all items" gets it's own li tags to display nicely like the other links in the facets column and it removes superfluous dots. To test in OPAC and Staff client: - Apply patch - Do a search that results in more than one available items - In column "Refine your search", click on "Limit to currently available items" - Verify that the message "Showing only available items" and the link "Show all items" display nicely. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> use_zebra_facets set to 0 in koha-conf.xml to test. Works as described Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Pushed to Master - Thanks! Patch pushed in 3.22.x, will be in 3.22.2 This patch has been pushed to 3.20.x, will be in 3.20.8. |