Bug 15345

Summary: Translatability: fix issue in facets (Availability')
Product: Koha Reporter: Marc Véron <veron>
Component: I18N/L10NAssignee: Marc Véron <veron>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: brendan, f.demians, hector.hecaxmmx, julian.maurice
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 15345: Translatability: fix issue in facets (Availability')
[SIGNED-OFF]Bug 15345: Translatability: fix issue in facets (Availability')
[PASSED QA] Bug 15345: Translatability: fix issue in facets (Availability')
Bug 15345: Translatability: fix issue in facets (Availability')

Description Marc Véron 2015-12-09 17:35:43 UTC
Fix issue with splitted sentence in facets (Avalability) that leads to weird translation, e.g. in German: Zeige nur Verfügbar Exemplare.
Comment 1 Marc Véron 2015-12-09 17:53:28 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2015-12-09 19:53:00 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2015-12-13 22:14:03 UTC Comment hidden (obsolete)
Comment 4 Brendan Gallagher 2015-12-29 20:24:58 UTC
Created attachment 46028 [details] [review]
Bug 15345: Translatability: fix issue in facets (Availability')

This patch fixes an issue with a splitted sentence in facets (Avalability)
that leads to weird translations e.g.:
German: 'Zeige nur Verfügbar Exemplare'
French: 'Montrer seulement disponible exemplaires'

Additionally, the link "Show all items" gets it's own li tags to display
nicely like the other links in the facets column and it removes superfluous
dots.

To test in OPAC and Staff client:
- Apply patch
- Do a search that results in more than one available items
- In column "Refine your search", click on "Limit to currently available
  items"
- Verify that the message "Showing only available items" and the link
  "Show all items" display nicely.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
use_zebra_facets set to 0 in koha-conf.xml to test. Works as described

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Comment 5 Brendan Gallagher 2015-12-29 20:25:14 UTC
Pushed to Master - Thanks!
Comment 6 Julian Maurice 2015-12-30 15:58:56 UTC
Patch pushed in 3.22.x, will be in 3.22.2
Comment 7 Frédéric Demians 2015-12-31 18:23:53 UTC
This patch has been pushed to 3.20.x, will be in 3.20.8.