Summary: | Sipserver problem with stale db handles | ||
---|---|---|---|
Product: | Koha | Reporter: | Colin Campbell <colin.campbell> |
Component: | SIP2 | Assignee: | Srdjan Jankovic <srdjan> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | colin.campbell, jonathan.druart, kyle, m.de.rooy, srdjan |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 15419 SIP: call auth() subs with timeout, and refresh dbh if need be
Bug 15419 SIP: handle requests with timeout, and refresh dbh if need be Bug 15419 SIP: handle requests with timeout, and refresh dbh if need be |
Description
Colin Campbell
2015-12-23 11:44:57 UTC
Created attachment 53071 [details] [review] Bug 15419 SIP: call auth() subs with timeout, and refresh dbh if need be To test: * Start SIP server * Make a request * Stop mysql daemon; start mysql daemon * Make another SIP request - it should not timeout on stale handle Created attachment 55273 [details] [review] Bug 15419 SIP: handle requests with timeout, and refresh dbh if need be (In reply to Srdjan Jankovic from comment #3) > Created attachment 55273 [details] [review] [review] > Bug 15419 SIP: handle requests with timeout, and refresh dbh if need be Do we need to timeout. DBI provides the ping method to test this If the question is "should we ping instead of timing out" I think pinging every time is too harsh on the database. But I'd like to hear opinions. Created attachment 57871 [details] [review] Bug 15419 SIP: handle requests with timeout, and refresh dbh if need be Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Is this still valid for new versions? I'd expect this to be fixed by bug 14778. Yes, that should be the case. (In reply to Srdjan Jankovic from comment #8) > Yes, that should be the case. So are you saying this bug should be closed, or it is still needed? Closed. Will reopen if needed. |