Bug 15550

Summary: Authority type pull down in OPAC authority search is empty
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: OPACAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: aleisha, brendan, jonathan.druart, julian.maurice
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 15381    
Bug Blocks:    
Attachments: Bug 15550: Fix authority search and detail at the OPAC
[SIGNED-OFF]Bug 15550: Fix authority search and detail at the OPAC
Bug 15550: Fix authority search and detail at the OPAC

Description Katrin Fischer 2016-01-11 20:57:43 UTC
In the authority search form in the OPAC the pull down for choosing the authority type appears empty.

Maybe similar to the bug report for the staff authority search?
Comment 1 Katrin Fischer 2016-01-11 20:58:20 UTC
Search dies with 

Can't call method "authtypetext" on an undefined value at /home/katrin/kohaclone/opac/opac-authorities-home.pl line 155.

Updating severity a bit.
Comment 2 Jonathan Druart 2016-01-12 10:29:33 UTC Comment hidden (obsolete)
Comment 3 Héctor Eduardo Castro Avalos 2016-01-12 20:43:21 UTC Comment hidden (obsolete)
Comment 4 Kyle M Hall 2016-01-15 16:59:10 UTC
Created attachment 46714 [details] [review]
Bug 15550: Fix authority search and detail at the OPAC

The author of Bug 15381 (me!) has mismatch the objects he was
manipulating and forgotten to update a template.
for the opac-aythorities-home, the variable is named authority_types,
not authtypesloop.
In opac-authoritiesdetail.pl, the $record is a MARC::Record and there is
no authtypecode method. We need to retrieve the authtypecode using
the new Koha::Authorities module.

Test plan:
Search for authorities at the OPAC and click on the detail link to go to
the detail page.
Without this patch, you will get errors.
With this patch, the errors should have gone and everything should work
as before bug 15381.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as described. Pull down for choosing the auth_type displayed again

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Katrin Fischer 2016-01-18 22:41:58 UTC
*** Bug 15575 has been marked as a duplicate of this bug. ***
Comment 6 Brendan Gallagher 2016-01-23 18:45:56 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!
Comment 7 Julian Maurice 2016-02-01 16:41:28 UTC
This bug does not concern stable versions, changing status to RESOLVED