Summary: | Use Font Awesome icons in reports when filter returns no results | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | brendan, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/reports/guided_reports.pl | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | |||
Bug Blocks: | 16062 | ||
Attachments: |
Bug 16061 - Use Font Awesome icons in reports when filter returns no results
Bug 16061 - Use Font Awesome icons in reports when filter returns no results Bug 16061: Use Font Awesome icons in reports when filter returns no results |
Description
Owen Leonard
2016-03-14 13:38:15 UTC
Created attachment 49096 [details] [review] Bug 16061 - Use Font Awesome icons in reports when filter returns no results In Reports -> Saved reports, when the filter form returns no results a dialog is shown. This patch updates the dialog to use Font Awesome icons. Also changed: The dialog now includes a button for creating a new SQL report, not just one to create a new guided report. The "clear" link in the sidebar has been modified to pass HTML validation. To test, apply the patch and go to Reports -> Saved reports. - In the left-hand sidebar filter, submit terms which will return no results. - Verify that the resulting dialog is correctly styled. - Confirm that all three buttons in the dialog work correctly: New guided report, new SQL report, and Cancel. Created attachment 49123 [details] [review] Bug 16061 - Use Font Awesome icons in reports when filter returns no results In Reports -> Saved reports, when the filter form returns no results a dialog is shown. This patch updates the dialog to use Font Awesome icons. Also changed: The dialog now includes a button for creating a new SQL report, not just one to create a new guided report. The "clear" link in the sidebar has been modified to pass HTML validation. To test, apply the patch and go to Reports -> Saved reports. - In the left-hand sidebar filter, submit terms which will return no results. - Verify that the resulting dialog is correctly styled. - Confirm that all three buttons in the dialog work correctly: New guided report, new SQL report, and Cancel. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 49146 [details] [review] Bug 16061: Use Font Awesome icons in reports when filter returns no results In Reports -> Saved reports, when the filter form returns no results a dialog is shown. This patch updates the dialog to use Font Awesome icons. Also changed: The dialog now includes a button for creating a new SQL report, not just one to create a new guided report. The "clear" link in the sidebar has been modified to pass HTML validation. To test, apply the patch and go to Reports -> Saved reports. - In the left-hand sidebar filter, submit terms which will return no results. - Verify that the resulting dialog is correctly styled. - Confirm that all three buttons in the dialog work correctly: New guided report, new SQL report, and Cancel. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> I'm passing this one, while I don't like it is hardcoding a URL path, because it will make is easier to spot it when time comes and we make Koha delpoyable in any endpoint. Pushed to Master - Should be in the May 2016 release. Thanks! |