Bug 16224

Summary: Random failure for t/db_dependent/Reports_Guided.t
Product: Koha Reporter: Julian Maurice <julian.maurice>
Component: Test SuiteAssignee: Julian Maurice <julian.maurice>
Status: CLOSED FIXED QA Contact: Galen Charlton <gmcharlt>
Severity: normal    
Priority: P5 - low CC: brendan, jonathan.druart
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 16224: Fix t/db_dependent/Reports_Guided.t
Bug 16224: Fix t/db_dependent/Reports_Guided.t
[PASSED QA] Bug 16224: Fix t/db_dependent/Reports_Guided.t

Description Julian Maurice 2016-04-07 15:00:25 UTC
This test:

is( scalar @{ get_saved_reports( $report_ids[0] ) }, 1, "filter takes report id" );

can fail when $report_ids[0] is a substring of some saved_sql fields from other reports (reports that have a different id than $report_ids[0]).
We can only be sure that get_saved_reports will return at least 1 report.
Comment 1 Julian Maurice 2016-04-07 15:05:03 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2016-04-11 11:02:46 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-04-11 11:03:07 UTC
Good catch Julian!
Comment 4 Katrin Fischer 2016-04-12 06:11:49 UTC
Created attachment 50138 [details] [review]
[PASSED QA] Bug 16224: Fix t/db_dependent/Reports_Guided.t

This test:

is( scalar @{ get_saved_reports( $report_ids[0] ) }, 1,
"filter takes report id" );

can fail when $report_ids[0] is a substring of some saved_sql fields
from other reports (reports that have a different id than
$report_ids[0]).
We can only be sure that get_saved_reports will return at least 1
report.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Brendan Gallagher 2016-04-20 19:49:26 UTC
Pushed to Master - Should be in the May 2016 Release.  Thanks!
Comment 6 Julian Maurice 2016-04-21 08:15:17 UTC
Patch pushed to 3.22.x, will be in 3.22.6