Created attachment 51557 [details] [review] Bug 16531: Circ overdue report is showing an empty table if no overdues To test: 1) Ensure you have no items overdue 2) Go to Circ -> Circulation reports -> Overdues 3) Notice empty table, '0 items overdue' heading 4) Apply patch and refresh page 5) Notice empty table is no longer showing and page prompts you to choose filters to see results 6) Check out an item to a member, ensure due date is a date that has passed (i.e. yesterday) 7) Refresh overdue report page 8) Confirm table now shows correctly with '1 items overdue' heading etc. Sponsored-by: Catalyst IT I think we can improve this page by giving the user more information about why nothing is displaying. I can think of two cases to plan for: 1. Nothing displays because there are no overdues. By default the overdue report show anything which is overdue, with no filters applied by default. If we know we're showing the unfiltered view, we can show a message which says "There are no overdues." 2. Nothing displays because the user has applied a filter to the results. ( "[% IF ( isfiltered ) %]" ). In this case we display a message which says something like, "There are no overdues matching your search." This would also allow us to display a link to "Reset filter," which is shown without this patch but isn't with the patch. Created attachment 51729 [details] [review] Bug 16531: Circ overdue report is showing an empty table if no overdues EDIT: Comment 2 To test: 1) Ensure you have no items overdue 2) Go to Circ -> Circulation reports -> Overdues 3) Notice empty table, '0 items overdue' heading 4) Apply patch and refresh page 5) Notice empty table is no longer showing and page says "There are no overdues" 6) Apply a filter to search 7) Page now says "There are no overdues matching your search" with a link to reset filter. 8) Click Reset filter -> confirm any filters you applied are cleared. 9) Check out an item to a member, ensure due date is a date that has passed (i.e. yesterday) 10) Refresh overdue report page 11) Confirm table now shows correctly with '1 items overdue' heading etc. Sponsored-by: Catalyst IT Created attachment 51769 [details] [review] [SIGNED-OFF] Bug 16531: Circ overdue report is showing an empty table if no overdues EDIT: Comment 2 To test: 1) Ensure you have no items overdue 2) Go to Circ -> Circulation reports -> Overdues 3) Notice empty table, '0 items overdue' heading 4) Apply patch and refresh page 5) Notice empty table is no longer showing and page says "There are no overdues" 6) Apply a filter to search 7) Page now says "There are no overdues matching your search" with a link to reset filter. 8) Click Reset filter -> confirm any filters you applied are cleared. 9) Check out an item to a member, ensure due date is a date that has passed (i.e. yesterday) 10) Refresh overdue report page 11) Confirm table now shows correctly with '1 items overdue' heading etc. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> With this patch, the noreport variable becomes useless. However it seems that it's useful in case of FilterBeforeOverdueReport is set. Please double check. Created attachment 53059 [details] [review] Bug 16531: Circ overdue report is showing an empty table if no overdues EDIT: Comment 2 EDIT2: using noreport variable (Comment 5) To test: 1) Ensure you have no items overdue 2) Go to Circ -> Circulation reports -> Overdues 3) Notice empty table, '0 items overdue' heading 4) Ensure syspref FilterBeforeOverdueReport is set to 'Don't require' 5) Apply patch and refresh page 6) Notice empty table is no longer showing and page says "There are no overdues" 7) Apply a filter to search 8) Page now says "There are no overdues matching your search" with a link to reset filter. 9) Click Reset filter -> confirm any filters you applied are cleared. 10) Set FilterBeforeOverdueReport to 'Require' and refresh overdue report 11) Page should say "Please choose one or more filters to proceed" 12) Check out an item to a member, ensure due date is a date that has passed (i.e. yesterday) 13) Refresh overdue report page 14) Page should still say "Please choose one or more filters to proceed" 15) Set FilterBeforeOverdueReport to 'Don't require' 16) Confirm table now shows correctly with '1 items overdue' heading etc. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 53322 [details] [review] [SIGNED-OFF] Bug 16531: Circ overdue report is showing an empty table if no overdues EDIT: Comment 2 EDIT2: using noreport variable (Comment 5) To test: 1) Ensure you have no items overdue 2) Go to Circ -> Circulation reports -> Overdues 3) Notice empty table, '0 items overdue' heading 4) Ensure syspref FilterBeforeOverdueReport is set to 'Don't require' 5) Apply patch and refresh page 6) Notice empty table is no longer showing and page says "There are no overdues" 7) Apply a filter to search 8) Page now says "There are no overdues matching your search" with a link to reset filter. 9) Click Reset filter -> confirm any filters you applied are cleared. 10) Set FilterBeforeOverdueReport to 'Require' and refresh overdue report 11) Page should say "Please choose one or more filters to proceed" 12) Check out an item to a member, ensure due date is a date that has passed (i.e. yesterday) 13) Refresh overdue report page 14) Page should still say "Please choose one or more filters to proceed" 15) Set FilterBeforeOverdueReport to 'Don't require' 16) Confirm table now shows correctly with '1 items overdue' heading etc. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 53434 [details] [review] Bug 16531: Circ overdue report is showing an empty table if no overdues EDIT: Comment 2 EDIT2: using noreport variable (Comment 5) To test: 1) Ensure you have no items overdue 2) Go to Circ -> Circulation reports -> Overdues 3) Notice empty table, '0 items overdue' heading 4) Ensure syspref FilterBeforeOverdueReport is set to 'Don't require' 5) Apply patch and refresh page 6) Notice empty table is no longer showing and page says "There are no overdues" 7) Apply a filter to search 8) Page now says "There are no overdues matching your search" with a link to reset filter. 9) Click Reset filter -> confirm any filters you applied are cleared. 10) Set FilterBeforeOverdueReport to 'Require' and refresh overdue report 11) Page should say "Please choose one or more filters to proceed" 12) Check out an item to a member, ensure due date is a date that has passed (i.e. yesterday) 13) Refresh overdue report page 14) Page should still say "Please choose one or more filters to proceed" 15) Set FilterBeforeOverdueReport to 'Don't require' 16) Confirm table now shows correctly with '1 items overdue' heading etc. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 16.11, thanks Aleisha! Pushed in 16.05. Will be in 16.05.02. Patch pushed to 3.22.x, will be in 3.22.10 |
Created attachment 51556 [details] Empty table