Description
Josef Moravec
2016-11-11 16:46:19 UTC
Created attachment 57460 [details] [review] Bug 17616: Select tag on elasticsearch mappings page is not closed properly Test plan 1) Have SearchEngine syspref set to Elastic 2) Look at source on admin/searchengine/elasticsearch/mappings.pl -> without patch you'll see select with attribute data-id="mapping_search_field_name" closing tag written badly as "/select>" -> with patch everything looks OK Created attachment 57472 [details] [review] Bug 17616: (follow-up)Select tag on elasticsearch mappings page is not closed properly Also some close tag </selected> should be </select> Follow previous patch to test Good catch Héctor. Created attachment 57682 [details] [review] [SIGNED-OFF] Bug 17616: Select tag on elasticsearch mappings page is not closed properly Test plan 1) Have SearchEngine syspref set to Elastic 2) Look at source on admin/searchengine/elasticsearch/mappings.pl -> without patch you'll see select with attribute data-id="mapping_search_field_name" closing tag written badly as "/select>" -> with patch everything looks OK Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 57683 [details] [review] [SIGNED-OFF] Bug 17616: (follow-up)Select tag on elasticsearch mappings page is not closed properly Also some close tag </selected> should be </select> Follow previous patch to test Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 57690 [details] [review] Bug 17616: Select tag on elasticsearch mappings page is not closed properly Test plan 1) Have SearchEngine syspref set to Elastic 2) Look at source on admin/searchengine/elasticsearch/mappings.pl -> without patch you'll see select with attribute data-id="mapping_search_field_name" closing tag written badly as "/select>" -> with patch everything looks OK Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 57691 [details] [review] Bug 17616: (follow-up)Select tag on elasticsearch mappings page is not closed properly Also some close tag </selected> should be </select> Follow previous patch to test Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Pushed to master for 16.11, thanks Josef, Lari! Some conflicts, skipping for 16.05.x |