Bug 17714

Summary: Remove itemtype-related t/db_dependent/Members/* warnings
Product: Koha Reporter: Tomás Cohen Arazi <tomascohen>
Component: Test SuiteAssignee: Tomás Cohen Arazi <tomascohen>
Status: CLOSED FIXED QA Contact: Galen Charlton <gmcharlt>
Severity: normal    
Priority: P5 - low CC: katrin.fischer, kyle, mtompset
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 17714: Remove itemtype-related t/db_dependent/Members/* warnings
[SIGNED-OFF] Bug 17714: Remove itemtype-related t/db_dependent/Members/* warnings
Bug 17714: Remove itemtype-related t/db_dependent/Members/* warnings

Description Tomás Cohen Arazi 2016-12-02 17:19:07 UTC
To reproduce:
- Run:
  $ prove t/db_dependent/Members/*
=> FAIL: itemtype-related warnings
Comment 1 Tomás Cohen Arazi 2016-12-02 17:21:55 UTC
Created attachment 57936 [details] [review]
Bug 17714: Remove itemtype-related t/db_dependent/Members/* warnings

This patch makes t/db_dependent/Members/* create
good sample data for its tests. It does so by creating a random
itemtype.

To test:
- Run
  $ prove t/db_dependent/Members/*
=> FAIL: lots of warnings about "item-level_itypes set but no itemtype
set for item"
- Apply the patch
- Run:
  $ prove t/db_dependent/Members/*
=> SUCCESS: Tests are green, and no warnings.
- Sign off :-D
Comment 2 Mark Tompsett 2016-12-02 19:11:25 UTC
Created attachment 57943 [details] [review]
[SIGNED-OFF] Bug 17714: Remove itemtype-related t/db_dependent/Members/* warnings

This patch makes t/db_dependent/Members/* create
good sample data for its tests. It does so by creating a random
itemtype.

To test:
- Run
  $ prove t/db_dependent/Members/*
=> FAIL: lots of warnings about "item-level_itypes set but no itemtype
set for item"
- Apply the patch
- Run:
  $ prove t/db_dependent/Members/*
=> SUCCESS: Tests are green, and no warnings.
- Sign off :-D

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Comment 3 Mark Tompsett 2016-12-02 19:12:14 UTC
P.S. Overzealous variable renaming item_infos. Still okay, but not necessary.
Comment 4 Tomás Cohen Arazi 2016-12-02 19:13:32 UTC
(In reply to M. Tompsett from comment #3)
> P.S. Overzealous variable renaming item_infos. Still okay, but not necessary.

Heh, I belived %item_branch_info was no longer a correct name, as it now includes 'itype'. But we could have lived without the change, yeah :-D
Comment 5 Jonathan Druart 2016-12-05 13:19:07 UTC
Created attachment 57958 [details] [review]
Bug 17714: Remove itemtype-related t/db_dependent/Members/* warnings

This patch makes t/db_dependent/Members/* create
good sample data for its tests. It does so by creating a random
itemtype.

To test:
- Run
  $ prove t/db_dependent/Members/*
=> FAIL: lots of warnings about "item-level_itypes set but no itemtype
set for item"
- Apply the patch
- Run:
  $ prove t/db_dependent/Members/*
=> SUCCESS: Tests are green, and no warnings.
- Sign off :-D

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 6 Kyle M Hall 2016-12-05 15:28:58 UTC
Pushed to master for 17.05, thanks Tomas!
Comment 7 Katrin Fischer 2016-12-05 20:29:01 UTC
This patch has been pushed to 16.11.x, will be in 16.11.01.