Bug 17851

Summary: Add Elasticsearch config to koha-conf.xml
Product: Koha Reporter: Olli-Antti Kivilahti <olli-antti.kivilahti>
Component: Searching - ElasticsearchAssignee: Johanna Räisä <johanna.raisa>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P5 - low CC: johanna.raisa, jonathan.druart, katrin.fischer, martin.renvoize, tomascohen
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18571
Change sponsored?: Sponsored Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
19.11.00
Attachments: Bug 17851 - Add elasticsearch config to koha-conf.xml
Bug 17851 - Add elasticsearch config to koha-conf.xml - Add missing entries to koha-install-log
Bug 17851 - Add elasticsearch config to koha-conf.xml
Bug 17851 - Add elasticsearch config to koha-conf.xml - Add missing entries to koha-install-log
Bug 17851 - Add elasticsearch config to koha-conf.xml
Bug 17851 - Add elasticsearch config to koha-conf.xml - Add missing entries to koha-install-log
Bug 17851: Add elasticsearch config to koha-conf.xml
Bug 17851: Add Elasticsearch config to koha-conf.xml - Add missing entries to koha-install-log

Description Olli-Antti Kivilahti 2017-01-05 12:05:45 UTC
Following the Elasticsearch installation instructions from:
https://wiki.koha-community.org/wiki/Elasticsearch

the <elasticsearch> config seems to be missing.

This patch adds interactive Elasticsearch-questions to the Makefile.PL to configure ES.
Comment 1 Olli-Antti Kivilahti 2017-01-05 12:14:51 UTC
Created attachment 58611 [details] [review]
Bug 17851 - Add elasticsearch config to koha-conf.xml

Missing installer for debian packages.
Comment 2 Olli-Antti Kivilahti 2017-01-13 15:10:01 UTC
Created attachment 58956 [details] [review]
Bug 17851 - Add elasticsearch config to koha-conf.xml - Add missing entries to koha-install-log
Comment 3 Tomás Cohen Arazi 2017-10-13 19:16:24 UTC
Olli, it would be great if you could rework this one, on top of 19465 (which takes care of packages). So strip that part out, and keep your addition to Makefile.PL and friends.
Thanks!
Comment 4 Tomás Cohen Arazi 2019-03-19 13:23:35 UTC
There's already <elasticsearch> in the koha-conf.xml* files. But you should recover the changes to Makefile.PL on this patchset, Olli.
Comment 5 Johanna Räisä 2019-07-04 11:53:33 UTC
Created attachment 91288 [details] [review]
Bug 17851 - Add elasticsearch config to koha-conf.xml

Fixed to apply master.
Comment 6 Johanna Räisä 2019-07-04 11:54:34 UTC
Created attachment 91289 [details] [review]
Bug 17851 - Add elasticsearch config to koha-conf.xml - Add missing entries to koha-install-log

Fixed to apply master.
Comment 7 Nick Clemens (kidclamp) 2019-10-03 09:40:04 UTC
Created attachment 93542 [details] [review]
Bug 17851 - Add elasticsearch config to koha-conf.xml

Missing installer for debian packages.

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Johanna Raisa <johanna.raisa@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 8 Nick Clemens (kidclamp) 2019-10-03 09:40:13 UTC
Created attachment 93543 [details] [review]
Bug 17851 - Add elasticsearch config to koha-conf.xml - Add missing entries to koha-install-log

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Johanna Raisa <johanna.raisa@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 9 Katrin Fischer 2019-10-03 09:57:23 UTC
Created attachment 93547 [details] [review]
Bug 17851: Add elasticsearch config to koha-conf.xml

Missing installer for debian packages.

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Johanna Raisa <johanna.raisa@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 10 Katrin Fischer 2019-10-03 09:57:35 UTC
Created attachment 93548 [details] [review]
Bug 17851: Add Elasticsearch config to koha-conf.xml - Add missing entries to koha-install-log

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Johanna Raisa <johanna.raisa@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 11 Katrin Fischer 2019-10-03 09:58:16 UTC
Fixed commit messages (Bug XXXX:)
Comment 12 Martin Renvoize 2019-10-07 13:10:18 UTC
Nice work!

Pushed to master for 19.11.00