Description
Katrin Fischer
2017-03-09 10:07:00 UTC
Created attachment 70570 [details] [review] Bug-18236: Add classes to material type Test plan: 1. Open a list of results 2. Use fn+f12 to inspect element 3. Without patch it should show that the image class is 'materialtype' 4. With patch the class should have changed -Books = mt_icon_bo Created attachment 70571 [details] [review] Bug-18236: Add classes to material type Test plan: 1. Open a list of results 2. Use fn+f12 to inspect element 3. Without patch it should show that the image class is 'materialtype' 4. With patch the class should have changed -Books = mt_icon_book -Kit = mt_icon_kit -Continuous resource = mt_icon_cresource -Mixed material = mixmaterial -Computer files = mt_icon_computer -Map = mt_icon_map -Score = mt_icon_score -Music = mt_icon_music OR 1. Try using the classes in css to change the style Test plan: 1. Open a list of results 2. Use fn+f12 to inspect element 3. Without patch it should show that the image class is 'materialtype' 4. With patch the class should have changed -Books = mt_icon_bo Bug-18236: Add classes to material type Test plan: 1. Open a list of results 2. Use fn+f12 to inspect element 3. Without patch it should show that the image class is 'materialtype' 4. With patch the class should have changed -Books = mt_icon_book -Kit = mt_icon_kit -Continuous resource = mt_icon_cresource -Mixed material = mixmaterial -Computer files = mt_icon_computer -Map = mt_icon_map -Score = mt_icon_score -Music = mt_icon_music OR 1. Try using the classes in css to change the style My commit message stuffed up so please use this test plan :) This looks great, but can I ask for more? It would be helpful if the icons kept the "materialtype" class along with the new class: <img src="/intranet-tmpl/prog/img/famfamfam/silk/book.png" alt="book" title="book" class="materialtype mt_icon_book"/> That would let us define common styles for all material type icons in addition to specific ones for specific types. Also: Could you include changes to MARC21slim2intranetDetail.xsl too? Thanks! Created attachment 70653 [details] [review] Bug-18236: Add classes to material type Test plan: -Following the test plan above, the class should still have 'materialtype' but also the new class: Books = mt_icon_BK Kit = mt_icon_MX Article = mt_icon_AR Mixed material = mt_icon_MX Computer files = mt_icon_CF Map = mt_icon_MP Music = mt_icon_MU Sound = mt_icon_MU Score = mt_icon_PR Visual material = mt_icon_VM -When viewing the details of a record, the material type img should also have the same changes -Check that the material type classes in the results page is the same as the details page Notes -The class names have changed from the previous patch in accordance to $materialTypeCode in MARC21slim2intranetDetail.xsl Patch does not apply. Created attachment 76149 [details] [review] Bug-18236: Add classes to material type Test plan: 1. Open a list of results 2. Use fn+f12 to inspect element 3. Without patch it should show that the image class is 'materialtype' 4. With patch the class should have changed -Books = mt_icon_book -Kit = mt_icon_kit -Continuous resource = mt_icon_cresource -Mixed material = mixmaterial -Computer files = mt_icon_computer -Map = mt_icon_map -Score = mt_icon_score -Music = mt_icon_music OR 1. Try using the classes in css to change the style Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 76150 [details] [review] Bug-18236: Add classes to material type Test plan: -Following the test plan above, the class should still have 'materialtype' but also the new class: Books = mt_icon_BK Kit = mt_icon_MX Article = mt_icon_AR Mixed material = mt_icon_MX Computer files = mt_icon_CF Map = mt_icon_MP Music = mt_icon_MU Sound = mt_icon_MU Score = mt_icon_PR Visual material = mt_icon_VM -When viewing the details of a record, the material type img should also have the same changes -Check that the material type classes in the results page is the same as the details page Notes -The class names have changed from the previous patch in accordance to $materialTypeCode in MARC21slim2intranetDetail.xsl Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 77375 [details] [review] Bug 18236: MARC21 - Add classes to material type on intranet detail and results pages Test plan: 1. Open a list of results 2. Use fn+f12 to inspect element 3. Without patch it should show that the image class is 'materialtype' 4. With patch there will be an additional class -Books = mt_icon_BK -Kit = mt_icon_MX -Article = mt_icon_AR -Continuous resource = mt_icon_CR -Mixed material = mt_icon_MX -Computer files = mt_icon_CF -Map = mt_icon_MP -Music = mt_icon_MU -Sound = mt_icon_MU -Score = mt_icon_PR -Visual material = mt_icon_VM OR 1. Try using the classes in css to change the style -When viewing the details of a record, the material type img should also have the same changes -Check that the material type classes in the results page is the same as the details page Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> I've squashed the patches to make chanes easier readable. It would be great if someone could include those changes in the OPAC as well, I've filed bug 21138. Awesome work all! Pushed to master for 18.11 Enhancement, will not be backported to 18.05.x series. |