Summary: | C4::Items - Remove GetItemLocation | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, katrin.fischer, m.de.rooy, veron |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18274 | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 18274 | ||
Bug Blocks: | 18252, 18279 | ||
Attachments: |
Bug 18278: C4::Items - Remove GetItemLocation
Bug 18278: C4::Items - Remove GetItemLocation Bug 18278: C4::Items - Remove GetItemLocation Bug 18278: C4::Items - Remove GetItemLocation Bug 18278: C4::Items - Remove GetItemLocation |
Description
Jonathan Druart
2017-03-15 20:13:02 UTC
Created attachment 61131 [details] [review] Bug 18278: C4::Items - Remove GetItemLocation This subroutine is no longer in used. It was previously call from serials/serials-recieve.pl, which was not used and has been removed by commit 65b7ad030cd5cd0e3148fbbd1496d31b5cf149f7 Bug 13423: Remove unused serials-recieve Test plan: git grep GetItemLocation git grep GetItemLocation Result: GetItemLocation in C4/Items.pm (line 70) Created attachment 61151 [details] [review] Bug 18278: C4::Items - Remove GetItemLocation This subroutine is no longer in used. It was previously call from serials/serials-recieve.pl, which was not used and has been removed by commit 65b7ad030cd5cd0e3148fbbd1496d31b5cf149f7 Bug 13423: Remove unused serials-recieve Test plan: git grep GetItemLocation Created attachment 61153 [details] [review] Bug 18278: C4::Items - Remove GetItemLocation This subroutine is no longer in used. It was previously call from serials/serials-recieve.pl, which was not used and has been removed by commit 65b7ad030cd5cd0e3148fbbd1496d31b5cf149f7 Bug 13423: Remove unused serials-recieve Test plan: git grep GetItemLocation Signed-off-by: Marc Véron <veron@veron.ch> With and without 18274 I get: Applying: Bug 18278: C4::Items - Remove GetItemLocation fatal: sha1 information is lacking or useless (C4/Items.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Created attachment 61975 [details] [review] Bug 18278: C4::Items - Remove GetItemLocation This subroutine is no longer in used. It was previously call from serials/serials-recieve.pl, which was not used and has been removed by commit 65b7ad030cd5cd0e3148fbbd1496d31b5cf149f7 Bug 13423: Remove unused serials-recieve Test plan: git grep GetItemLocation Signed-off-by: Marc Véron <veron@veron.ch> Applied ok for me, reattached. Created attachment 63916 [details] [review] Bug 18278: C4::Items - Remove GetItemLocation This subroutine is no longer in used. It was previously call from serials/serials-recieve.pl, which was not used and has been removed by commit 65b7ad030cd5cd0e3148fbbd1496d31b5cf149f7 Bug 13423: Remove unused serials-recieve Test plan: git grep GetItemLocation Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in v17.05.01. This is enhancement but since it is trivial I prefer to follow master to avoid future rebase conflicts. Patch doesn't apply cleanly to 16.11.x - please rebase for this version if you think it should be included. (In reply to Katrin Fischer from comment #11) > Patch doesn't apply cleanly to 16.11.x - please rebase for this version if > you think it should be included. No, I do not think it should. |