Bug 18413

Summary: Fix Letters.t (follow-up of 17866)
Product: Koha Reporter: Marcel de Rooy <m.de.rooy>
Component: Test SuiteAssignee: Marcel de Rooy <m.de.rooy>
Status: CLOSED FIXED QA Contact: Jonathan Druart <jonathan.druart>
Severity: enhancement    
Priority: P5 - low CC: jonathan.druart, kyle
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 17866    
Bug Blocks: 14723    
Attachments: Bug 18413: Fix Letters.t (following bug 17866)
Bug 18413: Fix Letters.t (following bug 17866)

Description Marcel de Rooy 2017-04-11 11:56:41 UTC
t/db_dependent/Letters.t .. 1/80 Can't call method "branchemail" on an undefined value at /home/vagrant/kohaclone/C4/Letters.pm line 576.
Comment 1 Marcel de Rooy 2017-04-11 12:18:15 UTC
Created attachment 62039 [details] [review]
Bug 18413: Fix Letters.t (following bug 17866)

SendAlert now needs a userenv to find branch email and the fallback
of KohaAdminEmailAddress if the branch mail is not filled.

Test plan:
Run t/db_dependent/Letters.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2017-04-11 12:18:58 UTC
Jonathan: please QA this one. Thanks
Comment 3 Jonathan Druart 2017-04-11 13:33:12 UTC
Created attachment 62042 [details] [review]
Bug 18413: Fix Letters.t (following bug 17866)

SendAlert now needs a userenv to find branch email and the fallback
of KohaAdminEmailAddress if the branch mail is not filled.

Test plan:
Run t/db_dependent/Letters.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Kyle M Hall 2017-04-13 12:09:33 UTC
Pushed to master for 17.05, thanks Marcel!