Bug 18553

Summary: Incorrect "Loading..." tag on moremember.tt when no clubs defined
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: PatronsAssignee: Nick Clemens (kidclamp) <nick>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: gmcharlt, jonathan.druart, katrin.fischer, kyle.m.hall, kyle
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 12461    
Bug Blocks: 18559    
Attachments: Bug 18553 - Incorrect "Loading..." tag on moremember.tt when no clubs defined
Bug 18553 - Incorrect "Loading..." tag on moremember.tt when no clubs defined
Bug 18553 - Incorrect "Loading..." tag on moremember.tt when no clubs defined
Bug 18553 - Incorrect Loading... tag on circulation.tt when no clubs defined

Description Nick Clemens (kidclamp) 2017-05-05 21:19:27 UTC

    
Comment 1 Nick Clemens (kidclamp) 2017-05-05 21:22:20 UTC
Created attachment 63215 [details] [review]
Bug 18553 - Incorrect "Loading..." tag on moremember.tt when no clubs defined

To test:
1 - Have no clubs
2 - View Details tab for a patron
3 - Note the 'Loading' tag near the tabs
4 - Apply patch
5 - Load patron details and notice 'Loading' is gone
6 - Add a club and verify tab shows as expected
Comment 2 Mark Tompsett 2017-05-06 03:00:00 UTC
Created attachment 63216 [details] [review]
Bug 18553 - Incorrect "Loading..." tag on moremember.tt when no clubs defined

To test:
1 - Have no clubs
2 - View Details tab for a patron
3 - Note the 'Loading' tag near the tabs
4 - Apply patch
5 - Load patron details and notice 'Loading' is gone
6 - Add a club and verify tab shows as expected

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Comment 3 Jonathan Druart 2017-05-08 15:50:05 UTC
Same on circulation.pl
Comment 4 Jonathan Druart 2017-05-08 15:51:16 UTC
(In reply to Jonathan Druart from comment #3)
> Same on circulation.pl

I am going to fix it.
Comment 5 Jonathan Druart 2017-05-08 15:55:43 UTC
Created attachment 63249 [details] [review]
Bug 18553 - Incorrect "Loading..." tag on moremember.tt when no clubs defined

To test:
1 - Have no clubs
2 - View Details tab for a patron
3 - Note the 'Loading' tag near the tabs
4 - Apply patch
5 - Load patron details and notice 'Loading' is gone
6 - Add a club and verify tab shows as expected

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 6 Jonathan Druart 2017-05-08 15:55:47 UTC
Created attachment 63250 [details] [review]
Bug 18553 - Incorrect Loading... tag on circulation.tt when no clubs defined

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 7 Kyle M Hall 2017-05-09 11:51:19 UTC
Pushed to master for 17.05, thanks Jonathan!
Comment 8 Katrin Fischer 2017-05-14 09:28:55 UTC
Depends on patrons clug feature, which is not in 16.11.x.