Bug 18627

Summary: Items created via MarcItemFieldsToOrder are not linked to orders
Product: Koha Reporter: Kyle M Hall <kyle>
Component: AcquisitionsAssignee: Kyle M Hall <kyle>
Status: CLOSED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: blocker    
Priority: P5 - low CC: katrin.fischer, m.de.rooy, nick
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 15503    
Bug Blocks:    
Attachments: Bug 18627 - Items created via MarcItemFieldsToOrder are not linked to orders
Bug 18627 - Items created via MarcItemFieldsToOrder are not linked to orders
Bug 18627 - Items created via MarcItemFieldsToOrder are not linked to orders

Description Kyle M Hall 2017-05-18 15:47:23 UTC
If using MarcItemFieldsToOrder with AcqCreateItem = Create, the order and the items will be created, but they will not be linked via aqorders_items!
Comment 1 Kyle M Hall 2017-05-18 15:53:53 UTC
Created attachment 63534 [details] [review]
Bug 18627 - Items created via MarcItemFieldsToOrder are not linked to orders

If using MarcItemFieldsToOrder with AcqCreateItem = Create,
the order and the items will be created, but they will not be linked via aqorders_items!

Test Plan:
1) Enable creation of items when ordering
2) Set up MarcItemFieldsToOrder
3) Upload an order record that uses the fields in step 2
4) Create a basket and add the records from the file
5) Note the order and items are created, but no rows in aqorders_items are created
6) Apply this patch
7) Repeat steps 3-4
8) Note the rows in aqorders_items are created!
Comment 2 Kyle M Hall 2017-05-18 18:57:16 UTC
Created attachment 63542 [details] [review]
Bug 18627 - Items created via MarcItemFieldsToOrder are not linked to orders

If using MarcItemFieldsToOrder with AcqCreateItem = Create,
the order and the items will be created, but they will not be linked via aqorders_items!

Test Plan:
1) Enable creation of items when ordering
2) Set up MarcItemFieldsToOrder
3) Upload an order record that uses the fields in step 2
4) Create a basket and add the records from the file
5) Note the order and items are created, but no rows in aqorders_items are created
6) Apply this patch
7) Repeat steps 3-4
8) Note the rows in aqorders_items are created!

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Marci Chen <mchen@mckinneytexas.org>
Comment 3 Marcel de Rooy 2017-05-19 05:43:13 UTC
QA: Looking here now
Comment 4 Marcel de Rooy 2017-05-19 06:32:16 UTC
Created attachment 63561 [details] [review]
Bug 18627 - Items created via MarcItemFieldsToOrder are not linked to orders

If using MarcItemFieldsToOrder with AcqCreateItem = Create,
the order and the items will be created, but they will not be linked via aqorders_items!

Test Plan:
1) Enable creation of items when ordering
2) Set up MarcItemFieldsToOrder
3) Upload an order record that uses the fields in step 2
4) Create a basket and add the records from the file
5) Note the order and items are created, but no rows in aqorders_items are created
6) Apply this patch
7) Repeat steps 3-4
8) Note the rows in aqorders_items are created!

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Marci Chen <mchen@mckinneytexas.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Kyle M Hall 2017-05-19 13:23:22 UTC
Pushed to master for 17.05!
Comment 6 Katrin Fischer 2017-05-21 20:55:24 UTC
Depends on the system preference added by bug 15503 which is not in 16.11.x.