Bug 18630

Summary: Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes
Product: Koha Reporter: Marc Véron <veron>
Component: PatronsAssignee: Marc Véron <veron>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: dilan, fridolin.somers, gmcharlt, josef.moravec, katrin.fischer, kyle.m.hall, kyle
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 18630: Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes
Patch fails to apply with fatal sha1 error
Bug 18630: Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes
[SIGNED-OFF] Bug 18630: Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes
Bug 18630: Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes

Description Marc Véron 2017-05-18 18:01:39 UTC
The button to cancel a club enrollement is labelled with 'Cancel'. That is ambiguous and translates e.g. in German to 'Abbrechen' which can lead to mistakes.
Comment 1 Marc Véron 2017-05-18 18:07:51 UTC
Created attachment 63536 [details] [review]
Bug 18630: Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes

The button to cancel a club enrollement is labelled with 'Cancel'. That is ambiguous and translates e.g. in German to 'Abbrechen' which can lead to
mistakes.

To test:
- Apply patch
- Enroll a patron to a club
- Enable public enrollment in OPAC
- Verify that the button to cancel enrollment in both OPAC and staff client
  reads 'Cancel enrollement' (instead of 'Cancel' without patch)
  (The button appears on the patron's detail pages in OPAC and staff client)
Comment 2 Dilan Johnpullé 2017-05-19 07:12:46 UTC
Created attachment 63563 [details]
Patch fails to apply with fatal sha1 error

Patch fails to apply with the attached error message being displayed.
Comment 3 Marc Véron 2017-05-19 07:25:26 UTC
(In reply to dilan from comment #2)
> Created attachment 63563 [details]
> Patch fails to apply with fatal sha1 error
> 
> Patch fails to apply with the attached error message being displayed.

Tested on current master:

git bz apply 18630

Applies cleanly here
Comment 4 Josef Moravec 2017-05-22 10:55:10 UTC
Just tested

1) I think the word "enrollement" should be "enrollment"
2) The patch fixes only OPAC, in staff client remains "Cancel"
Comment 5 Marc Véron 2017-05-22 15:40:35 UTC
Created attachment 63624 [details] [review]
Bug 18630: Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes

The button to cancel a club enrollement is labelled with 'Cancel'. That is ambiguous and translates e.g. in German to 'Abbrechen' which can lead to
mistakes.

To test:
- Apply patch
- Enroll a patron to a club
- Enable public enrollment in OPAC
- Verify that the button to cancel enrollment in both OPAC and staff client
  reads 'Cancel enrollement' (instead of 'Cancel' without patch)
  (The button appears on the patron's detail pages in OPAC and staff client)

Amended for comment #4 / mv
Comment 6 Josef Moravec 2017-05-23 04:18:03 UTC
Created attachment 63641 [details] [review]
[SIGNED-OFF] Bug 18630: Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes

The button to cancel a club enrollement is labelled with 'Cancel'. That is ambiguous and translates e.g. in German to 'Abbrechen' which can lead to
mistakes.

To test:
- Apply patch
- Enroll a patron to a club
- Enable public enrollment in OPAC
- Verify that the button to cancel enrollment in both OPAC and staff client
  reads 'Cancel enrollement' (instead of 'Cancel' without patch)
  (The button appears on the patron's detail pages in OPAC and staff client)

Amended for comment #4 / mv

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 7 Kyle M Hall 2017-06-15 14:06:52 UTC
Created attachment 64328 [details] [review]
Bug 18630: Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes

The button to cancel a club enrollement is labelled with 'Cancel'. That is ambiguous and translates e.g. in German to 'Abbrechen' which can lead to
mistakes.

To test:
- Apply patch
- Enroll a patron to a club
- Enable public enrollment in OPAC
- Verify that the button to cancel enrollment in both OPAC and staff client
  reads 'Cancel enrollement' (instead of 'Cancel' without patch)
  (The button appears on the patron's detail pages in OPAC and staff client)

Amended for comment #4 / mv

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 8 Jonathan Druart 2017-06-15 19:09:13 UTC
Pushed to master for 17.11, thanks to everybody involved!
Comment 9 Fridolin Somers 2017-06-27 14:22:28 UTC
Pushed to 17.05.x, will be in 17.05.02
Comment 10 Katrin Fischer 2017-06-27 21:33:33 UTC
No clubs in 16.11.x.