Summary: | Translatability: Get rid of exposing a [%% FOREACH loop in translation for branch-selector.inc | ||
---|---|---|---|
Product: | Koha | Reporter: | Marc Véron <veron> |
Component: | I18N/L10N | Assignee: | Marc Véron <veron> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | f.demians, fridolin.somers, jonathan.druart, katrin.fischer |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 18693: Translatability: Get rid of exposing a [%% FOREACH loop in translation for branch-selector.inc
Bug 18693: Translatability: Get rid of exposing a [%% FOREACH loop in translation for branch-selector.inc |
Description
Marc Véron
2017-05-30 05:11:08 UTC
Additionally, export.tt exposes the following line to translation: [%% INCLUDE 'branch-selector.inc' branches = libraries %%] Created attachment 63834 [details] [review] Bug 18693: Translatability: Get rid of exposing a [%% FOREACH loop in translation for branch-selector.inc The file branch-selector.inc exposes the following line to translation (due to newlines insied a tt directive): %s %s [%% FOREACH branch IN branches; IF branch.selected; selectall = 0; END; END %%] Additionally, export.tt exposes the following line to translation: [%% INCLUDE 'branch-selector.inc' branches = libraries %%] To test: - Apply patch - In Staff client, go to Home > Tools > Export data - Verify that library selection behaves as before - Bonus test: Create a "language" aa-AA (perl translate create aa-AA from folder misc/translator, verify that lines mentioned above do no longer appear in aa-AA-staff-prog.po - Run QA tools (newest version with test for newlines in tt directives) Created attachment 63992 [details] [review] Bug 18693: Translatability: Get rid of exposing a [%% FOREACH loop in translation for branch-selector.inc The file branch-selector.inc exposes the following line to translation (due to newlines insied a tt directive): %s %s [%% FOREACH branch IN branches; IF branch.selected; selectall = 0; END; END %%] Additionally, export.tt exposes the following line to translation: [%% INCLUDE 'branch-selector.inc' branches = libraries %%] To test: - Apply patch - In Staff client, go to Home > Tools > Export data - Verify that library selection behaves as before - Bonus test: Create a "language" aa-AA (perl translate create aa-AA from folder misc/translator, verify that lines mentioned above do no longer appear in aa-AA-staff-prog.po - Run QA tools (newest version with test for newlines in tt directives) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Trivial, skipping QA. Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.01 This patch has been pushed to 16.11.x and will be in 16.11.09. |