Summary: | Text_CSV_Various.t parse failure | ||
---|---|---|---|
Product: | Koha | Reporter: | Lee Jamison <ldjamison> |
Component: | Test Suite | Assignee: | Mark Tompsett <mtompset> |
Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, katrin.fischer, mtj |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 18746: Text_CSV_Various parse failures
Bug 18746: Text_CSV_Various parse failures Bug 18746: Text_CSV_Various parse failures Bug 18746: Add license and remove diag |
Description
Lee Jamison
2017-06-07 15:51:43 UTC
It seems that the failures are expected. I'd suggest to remove this file. Created attachment 64091 [details] [review] Bug 18746: Text_CSV_Various parse failures While it might be an idea to just delete it, this patch attempts to catch everything and make it clear that Text::CSV::Unicode (binary) is the parser that should be used. Let's give it a try! Created attachment 64110 [details] [review] Bug 18746: Text_CSV_Various parse failures While it might be an idea to just delete it, this patch attempts to catch everything and make it clear that Text::CSV::Unicode (binary) is the parser that should be used. Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Running 'prove xt/author/Text_CSV_Various.t' passes Created attachment 64130 [details] [review] Bug 18746: Text_CSV_Various parse failures While it might be an idea to just delete it, this patch attempts to catch everything and make it clear that Text::CSV::Unicode (binary) is the parser that should be used. Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Running 'prove xt/author/Text_CSV_Various.t' passes Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 64131 [details] [review] Bug 18746: Add license and remove diag Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.01 This patch has been pushed to 16.11.x and will be in 16.11.09. Pushed to 16.05.x, for 16.05.15 release |