Description
Jonathan Druart
2017-07-25 19:56:41 UTC
Created attachment 65261 [details] [review] Bug 18982: Use KOHA_INTRANET_URL instead of syspref staffClientBaseURL That way we do not need to set the syspref, we can define it setting an env var, like other tests. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 65262 [details] [review] Bug 18982: category.categorycode must be uppercase Otherwise it is not selected in the dropdown list and the patron created does not belong to this category Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 65263 [details] [review] Bug 18982: Create a specific itemtype for these tests No need to require rentalcharge=0 for all itemtypes, we create our own. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 65264 [details] [review] Bug 18982: Create a circ rule for the data we created No need to have a default circ cule, we create one for the categorycode and itemtype we are going to use. The 3 checkouts will not be rejected (5 are allowed) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Skipping SO & QA, they are needed to make Jenkins happy. Pushed to master for 17.11. Created attachment 65268 [details] [review] Bug 18982: Use KOHA_INTRANET_URL instead of syspref staffClientBaseURL That way we do not need to set the syspref, we can define it setting an env var, like other tests. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Andrei <acovaliov@gmail.com> Created attachment 65269 [details] [review] Bug 18982: category.categorycode must be uppercase Otherwise it is not selected in the dropdown list and the patron created does not belong to this category Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Andrei <acovaliov@gmail.com> Created attachment 65270 [details] [review] Bug 18982: Create a specific itemtype for these tests No need to require rentalcharge=0 for all itemtypes, we create our own. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Andrei <acovaliov@gmail.com> Created attachment 65271 [details] [review] Bug 18982: Create a circ rule for the data we created No need to have a default circ cule, we create one for the categorycode and itemtype we are going to use. The 3 checkouts will not be rejected (5 are allowed) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Andrei <acovaliov@gmail.com> Created attachment 65282 [details] [review] Bug 18982: Remove data in the correct order To respect FK Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> The last patch has been pushed to master for 17.11 Pushed to 17.05.x, will be in 17.05.03. Hm, I installed the module, but still seeing: ok 1 # skip Selenium::Remote::Driver is needed for selenium tests These patches have been pushed to 16.11.x and will be in 16.11.10. Sorry, 16.11.11! (In reply to Katrin Fischer from comment #14) > Hm, I installed the module, but still seeing: > ok 1 # skip Selenium::Remote::Driver is needed for selenium tests What returns `pmversion Selenium::Remote::Driver`? You could also try to remove the eval in the SKIP block to know what is the error. Pushed to 16.05.x, for 16.05.16 release |