Bug 19058

Summary: Move C4::Reserves::GetReserveId to Koha::Holds
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers, veron
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 19057    
Bug Blocks: 17728, 19059, 19766    
Attachments: Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace
Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace
[SIGNED-OFF] Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace
Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace

Description Jonathan Druart 2017-08-07 21:01:32 UTC
GetReserveId can easily be replaced with a call to Koha::Holds->search->next->reserve_id

It will ease next changes to use Koha::Hold objects
Comment 1 Jonathan Druart 2017-08-07 21:02:56 UTC Comment hidden (obsolete)
Comment 2 Marc VĂ©ron 2017-08-08 08:52:53 UTC
t/db_dependent/Holds.t complains because of tests count (You planned 56 tests but ran 55).
Comment 3 Jonathan Druart 2017-08-08 11:57:55 UTC
Created attachment 65629 [details] [review]
Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace

GetReserveId can easily be replaced with a call to
Koha::Holds->search->next->reserve_id

It will ease next changes to use Koha::Hold objects

Test plan:
Cancel a reserve and print a slip reserve
Comment 4 Owen Leonard 2017-08-08 13:05:39 UTC
Created attachment 65635 [details] [review]
[SIGNED-OFF] Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace

GetReserveId can easily be replaced with a call to
Koha::Holds->search->next->reserve_id

It will ease next changes to use Koha::Hold objects

Test plan:
Cancel a reserve and print a slip reserve

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 5 Kyle M Hall 2017-09-01 18:21:27 UTC
Created attachment 66778 [details] [review]
Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace

GetReserveId can easily be replaced with a call to
Koha::Holds->search->next->reserve_id

It will ease next changes to use Koha::Hold objects

Test plan:
Cancel a reserve and print a slip reserve

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Jonathan Druart 2017-09-01 20:20:22 UTC
Pushed to master for 17.11, thanks to everybody involved!
Comment 7 Fridolin Somers 2017-10-10 09:09:18 UTC
Enhancement not pushed to 17.05.x