Bug 19940

Summary: Koha::Biblio - Remove GetBiblioItemInfosOf
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: enhancement    
Priority: P5 - low CC: m.de.rooy, nick
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 17628, 19941    
Attachments: Bug 19940: Koha::Biblio - Remove GetBiblioItemInfosOf
Bug 19940: Koha::Biblio - Remove GetBiblioItemInfosOf
Bug 19940: Koha::Biblio - Remove GetBiblioItemInfosOf

Description Jonathan Druart 2018-01-09 17:00:18 UTC
This subroutine is only used once and can be replaced easily with a Koha::Biblioitems->search call
Comment 1 Jonathan Druart 2018-01-09 17:19:27 UTC
Created attachment 70381 [details] [review]
Bug 19940: Koha::Biblio - Remove GetBiblioItemInfosOf

This subroutine is only used once and can be replaced easily with a
Koha::Biblioitems->search call

Test plan:
Test this on top of bug 19941 and confirm that the correct item types
are displayed
Comment 2 Tomás Cohen Arazi 2018-03-05 16:53:08 UTC
Created attachment 72438 [details] [review]
Bug 19940: Koha::Biblio - Remove GetBiblioItemInfosOf

This subroutine is only used once and can be replaced easily with a
Koha::Biblioitems->search call

Test plan:
Test this on top of bug 19941 and confirm that the correct item types
are displayed

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Comment 3 Marcel de Rooy 2018-03-09 07:42:22 UTC
QA: Looking here
Comment 4 Marcel de Rooy 2018-03-09 07:51:21 UTC
Created attachment 72555 [details] [review]
Bug 19940: Koha::Biblio - Remove GetBiblioItemInfosOf

This subroutine is only used once and can be replaced easily with a
Koha::Biblioitems->search call

Test plan:
Test this on top of bug 19941 and confirm that the correct item types
are displayed

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Jonathan Druart 2018-03-23 15:36:28 UTC
Pushed to master for 18.05, thanks to everybody involved!
Comment 6 Nick Clemens 2018-03-26 12:12:25 UTC
Enhancement, not backported for 17.11