Bug 20063

Summary: $9 is lost when cataloguing authority records
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: CatalogingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: fridolin.somers, m.de.rooy, nick
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 18811    
Bug Blocks:    
Attachments: Bug 20063: (bug 18811 follow-up) Allow hidden $9 subfields

Description Jonathan Druart 2018-01-22 16:44:19 UTC
Bug 18811 has terrible side-effects:

commit 7e222bb0796196f1e466b73d909fd28d529cab75
Bug 18811: Change visibility checks in authorities.pl

next if $tagslib->{$tag}->{$subfield}->{hidden};

I was trying to test the AuthDisplayHierarchy behaviour and notice that the $9 was not filled with the related (broader) authority id. Indeed it is hidden.

See bug 18811 comment 33
Comment 1 Jonathan Druart 2018-01-22 16:45:31 UTC
Created attachment 70803 [details] [review]
Bug 20063: (bug 18811 follow-up) Allow hidden $9 subfields

Although we could argue that the user should make all $9 subfields
visible, this might be a good compromise. It selectively reverts the
change from the first patch by accepting $9 subfields without checking
the hidden flag in the framework.

Test plan:
[1] Make a subfield $9 visible for some authority field.
[2] Put a value in it somewhere in authorities.pl
[3] Make subfield $9 invisible in the auth framework.
[4] Open and save the adjusted authority record.
[5] Check the marcxml of this record.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 2 Jonathan Druart 2018-01-22 16:48:56 UTC
Pushed to master for 18.05
Comment 3 Nick Clemens 2018-01-23 04:18:57 UTC
Awesome work all!

Pushed to stable for 17.11.02
Comment 4 Fridolin Somers 2018-01-23 07:52:43 UTC
Pushed to 17.05.x for v17.05.08