Bug 20082

Summary: Vietnamese language display name is incorrect
Product: Koha Reporter: dcowens76
Component: I18N/L10NAssignee: Katrin Fischer <katrin.fischer>
Status: CLOSED FIXED QA Contact: Josef Moravec <josef.moravec>
Severity: minor    
Priority: P5 - low CC: f.demians, josef.moravec, katrin.fischer, roch.damour
Version: 17.11   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 20082: Correct description of Vietnamese language and add German translation
Bug 20082: Correct description of Vietnamese language and add German translation
Bug 20082: Correct description of Vietnamese language and add German translation

Description dcowens76 2018-01-24 02:12:11 UTC
Currently the vi-VN language display name is in Chinese characters (㗂越). This is incorrect. 

To reproduce this, install the vi-VN language and open the OPAC. The option for Vietnamese will display as those Chinese characters, rather than "Tiếng Việt", which is the way Vietnamese people refer to their language. 

The display name is created by the installer in installer/data/mysql/mandatory/subtag_registry.sql:

VALUES ( 'vi', 'language', 'vi', '㗂越');

That should be changed to: 

VALUES ( 'vi', 'language', 'vi', 'Tiếng Việt');
Comment 1 Katrin Fischer 2018-02-01 06:51:19 UTC
Created attachment 71103 [details] [review]
Bug 20082: Correct description of Vietnamese language and add German translation

Fixes the language description of Vietnamese according to the
bug report and adds the German translation for the language
name.

To test:
- Run the database update
- Verify that the new descriptions Tiếng Việt shows
  in advanced search language pull down
- Install German translations
- Verify that the German translation 'Vietnamesisch'
  shows in the pull down when German is selected.
Comment 2 Roch D'Amour 2018-02-23 21:06:59 UTC
Created attachment 72160 [details] [review]
Bug 20082: Correct description of Vietnamese language and add German translation

Fixes the language description of Vietnamese according to the
bug report and adds the German translation for the language
name.

To test:
- Run the database update
- Verify that the new descriptions Tiếng Việt shows
  in advanced search language pull down
- Install German translations
- Verify that the German translation 'Vietnamesisch'
  shows in the pull down when German is selected.

Signed-off-by: Roch D'Amour <roch.damour@inlibro.com>
Comment 3 Josef Moravec 2018-02-25 09:00:43 UTC
Created attachment 72184 [details] [review]
Bug 20082: Correct description of Vietnamese language and add German translation

Fixes the language description of Vietnamese according to the
bug report and adds the German translation for the language
name.

To test:
- Run the database update
- Verify that the new descriptions Tiếng Việt shows
  in advanced search language pull down
- Install German translations
- Verify that the German translation 'Vietnamesisch'
  shows in the pull down when German is selected.

Signed-off-by: Roch D'Amour <roch.damour@inlibro.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 4 Jonathan Druart 2018-02-26 16:29:10 UTC
Pushed to master for 18.05, thanks to everybody involved!