Bug 20119

Summary: Ability to print claims for late orders
Product: Koha Reporter: Alex Arnaud <alex.arnaud>
Component: AcquisitionsAssignee: Alex Arnaud <alex.arnaud>
Status: Patch doesn't apply --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: amit.gupta, amitddng135, fridolin.somers, katrin.fischer, severine.queune
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20125
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18796
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 20119 - Ability to print claims for late orders
Bug 20119 - Add a script to claim late orders (ordersClaim.pl)
Bug 20119 - Ability to print claims for late orders
Bug 20119 - Add unit tests
Bug 20119 - Ability to print claims for late orders
Bug 20119 - Add unit tests
Bug 20119 - Ability to print claims for late orders
Bug 20119 - Add unit tests
Bug 20119 - Ability to print claims for late orders
Bug 20119 - Add unit tests
Bug 20119: Add option to update claims count and claim date

Description Alex Arnaud 2018-02-01 10:23:10 UTC
We need the ability to print order claims as pdf in the late orders page.
Also, we need a cron script that send claims by email.

Patch is coming
Comment 1 Alex Arnaud 2018-02-01 10:40:34 UTC
Created attachment 71106 [details] [review]
Bug 20119 - Ability to print claims for late orders
Comment 2 Alex Arnaud 2018-02-01 10:40:40 UTC
Created attachment 71107 [details] [review]
Bug 20119 - Add a script to claim late orders (ordersClaim.pl)
Comment 3 Katrin Fischer 2018-02-01 21:59:14 UTC
Hi Alex, maybe this should be 2 bugs? Also please make sure to add test plans and a bit more information to your commit messages!
Comment 4 Katrin Fischer 2018-02-01 22:00:01 UTC
By splitting into 2 bugs with better descriptions this will also stand out more in the release notes :)
Comment 5 Alex Arnaud 2018-02-02 09:03:10 UTC
(In reply to Katrin Fischer from comment #4)
> By splitting into 2 bugs with better descriptions this will also stand out
> more in the release notes :)

You are right.
Comment 6 Alex Arnaud 2018-02-02 09:17:09 UTC Comment hidden (obsolete)
Comment 7 Alex Arnaud 2018-02-02 14:13:48 UTC Comment hidden (obsolete)
Comment 8 Alex Arnaud 2018-02-02 14:13:53 UTC Comment hidden (obsolete)
Comment 9 Séverine Queune 2018-03-14 13:11:01 UTC Comment hidden (obsolete)
Comment 10 Alex Arnaud 2018-03-15 11:06:57 UTC
Created attachment 72928 [details] [review]
Bug 20119 - Ability to print claims for late orders

Test plan:

 - create a notice: module: claimacquisition, code: ACQCLAIM: transport:
   print
 - create at least a bookseller, basket and orders,
 - close the basket and change the closedate to make orders late,
 - go to cgi-bin/koha/acqui/lateorders.pl,
 - select one or more order(s) to claim and click on "Print claim",
 - check the pdf downloaded

[2018-03-15] Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com>
Comment 11 Alex Arnaud 2018-03-15 11:07:04 UTC
Created attachment 72929 [details] [review]
Bug 20119 - Add unit tests

[2018-03-15] Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com>
Comment 12 Séverine Queune 2018-03-15 12:56:37 UTC
Created attachment 72944 [details] [review]
Bug 20119 - Ability to print claims for late orders

Test plan:

 - create a notice: module: claimacquisition, code: ACQCLAIM: transport:
   print
 - create at least a bookseller, basket and orders,
 - close the basket and change the closedate to make orders late,
 - go to cgi-bin/koha/acqui/lateorders.pl,
 - select one or more order(s) to claim and click on "Print claim",
 - check the pdf downloaded

[2018-03-15] Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com>

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Comment 13 Séverine Queune 2018-03-15 12:56:43 UTC
Created attachment 72945 [details] [review]
Bug 20119 - Add unit tests

[2018-03-15] Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com>

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Comment 14 Séverine Queune 2018-03-15 13:42:09 UTC
The current patch (that works perfectly for pdf export) doesn't update the claims count nor the claimed date.
Is it a behaviour we want to keep ? In that case, as the claims count is update only when emailing the vendor, there is no way in Koha to trace the "paper claims".
But, in the other hand, there is no garanty that the claim pdf will be send to the vendor, or the date of sending can be different of the one in Koha so it's not necesarly a good idea to update these informations at the printing moment.
I don't know which behaviour is better.
Comment 15 Katrin Fischer 2018-03-31 09:51:52 UTC
Could we add a checkbox or a confirmation question? That way the library could decide when the count is updated.
Comment 16 Séverine Queune 2018-04-09 08:07:52 UTC
(In reply to Katrin Fischer from comment #15)
> Could we add a checkbox or a confirmation question? That way the library
> could decide when the count is updated.

That's a good idea !
Comment 17 Alex Arnaud 2021-10-06 14:48:02 UTC
Created attachment 125823 [details] [review]
Bug 20119 - Ability to print claims for late orders

Test plan:

 - create a notice: module: claimacquisition, code: ACQCLAIM: transport:
   print
 - create at least a bookseller, basket and orders,
 - close the basket and change the closedate to make orders late,
 - go to cgi-bin/koha/acqui/lateorders.pl,
 - select one or more order(s) to claim and click on "Print claim",
 - check the pdf downloaded

[2018-03-15] Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com>

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Comment 18 Alex Arnaud 2021-10-06 14:48:15 UTC
Created attachment 125824 [details] [review]
Bug 20119 - Add unit tests

[2018-03-15] Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com>

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Comment 19 Alex Arnaud 2021-10-06 14:48:24 UTC
Created attachment 125825 [details] [review]
Bug 20119: Add option to update claims count and claim date
Comment 20 Alex Arnaud 2021-10-06 14:50:13 UTC
Patches rebased on master.
I attached a new one that add an option for updating claims count and claim date.
Comment 21 Katrin Fischer 2022-07-30 20:02:21 UTC
Hi Alex, could you please rebase?

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 20119 - Ability to print claims for late orders
Applying: Bug 20119 - Add unit tests
error: sha1 information is lacking or useless (C4/Letters.pm).
error: could not build fake ancestor
Patch failed at 0001 Bug 20119 - Add unit tests
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-20119---Add-unit-tests-BTwZip.patch