Bug 20494

Summary: Remove unused code in neworderempty.pl and addbiblio.pl
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: Architecture, internals, and plumbingAssignee: Nick Clemens (kidclamp) <nick>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: jonathan.druart
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 20494 - Remove unused code in neworderempty.pl and addbiblio.pl
Bug 20494 - Remove unused code in neworderempty.pl and addbiblio.pl
Bug 20494: Remove unused code in neworderempty.pl and addbiblio.pl

Description Nick Clemens (kidclamp) 2018-03-29 12:35:06 UTC
z3950authortemplate is referenced in some comments and there are a few other lines commented out that seem to be cruft
Comment 1 Nick Clemens (kidclamp) 2018-03-29 12:37:43 UTC
Created attachment 73421 [details] [review]
Bug 20494 - Remove unused code in neworderempty.pl and addbiblio.pl

Should be sufficient to read code and see all lines were commented and
that this patch removes useless lines

To be thorough, ensure that your can add an order to a basket and add a
biblio.
Comment 2 Mark Tompsett 2018-03-29 18:58:51 UTC
Created attachment 73441 [details] [review]
Bug 20494 - Remove unused code in neworderempty.pl and addbiblio.pl

Should be sufficient to read code and see all lines were commented and
that this patch removes useless lines

To be thorough, ensure that your can add an order to a basket and add a
biblio.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Comment 3 Katrin Fischer 2018-03-30 08:56:45 UTC
Created attachment 73454 [details] [review]
Bug 20494: Remove unused code in neworderempty.pl and addbiblio.pl

Should be sufficient to read code and see all lines were commented and
that this patch removes useless lines

To be thorough, ensure that your can add an order to a basket and add a
biblio.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Jonathan Druart 2018-04-02 21:15:42 UTC
Pushed to master for 18.05, thanks to everybody involved!