Bug 20498

Summary: Patron advanced search form missing from patron entry page
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: jonathan.druart, testopia
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 19641    
Bug Blocks:    
Attachments: Bug 20498 - Patron advanced search form missing from patron entry page
Bug 20498: (bug 19641 follow-up) Patron advanced search form missing from patron entry page

Description Owen Leonard 2018-03-29 17:52:39 UTC
My patch for Bug 19641 neglected to add members-menu.js to the patron entry template.
Comment 1 Owen Leonard 2018-03-29 18:01:07 UTC
Created attachment 73437 [details] [review]
Bug 20498 - Patron advanced search form missing from patron entry page

My patch moving patron-related templates' javascript to the footer left
out a script from the patron entry template which is required if the
patron header search menu is going to work.

To test, apply the patch and go to Patrons -> New patron.

Clicking the [+] link in the "Search patrons" header search form should
expand the advanced search options.

Test that the page's toolbar still "floats" correctly when you scroll
the page.
Comment 2 Jonathan Druart 2018-03-29 18:31:57 UTC
Created attachment 73438 [details] [review]
Bug 20498: (bug 19641 follow-up) Patron advanced search form missing from patron entry page

My patch moving patron-related templates' javascript to the footer left
out a script from the patron entry template which is required if the
patron header search menu is going to work.

To test, apply the patch and go to Patrons -> New patron.

Clicking the [+] link in the "Search patrons" header search form should
expand the advanced search options.

Test that the page's toolbar still "floats" correctly when you scroll
the page.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 3 Jonathan Druart 2018-03-29 18:32:48 UTC
Thanks Owen!

Considered a follow-up of bug 19641, Pushed to master for 18.05