Summary: | svc/barcode should allow barcode to be printed without text | ||
---|---|---|---|
Product: | Koha | Reporter: | Barton Chittenden <barton> |
Component: | Web services | Assignee: | Barton Chittenden <barton> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | f.demians, kyle, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20894 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
Extends Koha /svc/barcode HTTP API. Adds a notext=1 parameter to the entry point in order to prevent the display of barcode text under the barcode's image.
|
Version(s) released in: | |
Bug Depends on: | 13545 | ||
Bug Blocks: | 23144 | ||
Attachments: |
Bug 20676: svc/barcode should allow barcode to be printed without text
Bug 20676: svc/barcode should allow barcode to be printed without text Bug 20676: svc/barcode should allow barcode to be printed without text Bug 20676: svc/barcode should allow barcode to be printed without text Bug 20676: svc/barcode should allow barcode to be printed without text |
Description
Barton Chittenden
2018-04-27 21:30:43 UTC
Created attachment 74915 [details] [review] Bug 20676: svc/barcode should allow barcode to be printed without text Test plan: 1) Point web browser to <staff url>/cgi-bin/koha/svc/barcode?barcode=*12345*&nobarcode This will display a png image of the barcode 12345 with the text 12345 printed below the scannable barcode. 2) Apply patch 3) Refresh the browser. The human readable text no longer appears. Created attachment 74939 [details] [review] Bug 20676: svc/barcode should allow barcode to be printed without text Test plan: 1) Point web browser to <staff url>/cgi-bin/koha/svc/barcode?barcode=*12345*¬ext=1 This will display a png image of the barcode *12345* with the text *12345* printed below the scannable barcode. 2) Apply patch 3) Refresh the browser. The human readable text no longer appears. Created attachment 74940 [details] [review] Bug 20676: svc/barcode should allow barcode to be printed without text Test plan: 1) Point web browser to <staff url>/cgi-bin/koha/svc/barcode?barcode=*12345*¬ext=1 This will display a png image of the barcode *12345* with the text *12345* printed below the scannable barcode. 2) Apply patch 3) Refresh the browser. The human readable text no longer appears. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Created attachment 74942 [details] [review] Bug 20676: svc/barcode should allow barcode to be printed without text Test plan: 1) Point web browser to <staff url>/cgi-bin/koha/svc/barcode?barcode=*12345*¬ext=1 This will display a png image of the barcode *12345* with the text *12345* printed below the scannable barcode. 2) Apply patch 3) Refresh the browser. The human readable text no longer appears. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> (In reply to Barton Chittenden from comment #4) > Created attachment 74942 [details] [review] [review] > Bug 20676: svc/barcode should allow barcode to be printed without text > > Test plan: > > 1) Point web browser to > <staff url>/cgi-bin/koha/svc/barcode?barcode=*12345*¬ext=1 > > This will display a png image of the barcode *12345* with the > text *12345* printed below the scannable barcode. > > 2) Apply patch > 3) Refresh the browser. The human readable text no longer appears. > > Signed-off-by: Frédéric Demians <f.demians@tamil.fr> This was just removing warnings that I was using for debugging. Created attachment 75600 [details] [review] Bug 20676: svc/barcode should allow barcode to be printed without text Test plan: 1) Point web browser to <staff url>/cgi-bin/koha/svc/barcode?barcode=*12345*¬ext=1 This will display a png image of the barcode *12345* with the text *12345* printed below the scannable barcode. 2) Apply patch 3) Refresh the browser. The human readable text no longer appears. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Awesome work all! Pushed to master for 18.11.x Enhancement, not backporting for 18.05.x series. |