Bug 20739

Summary: Update two-column templates with Bootstrap grid: Administration part 3
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: jonathan.druart, martin.renvoize, nick, testopia
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 20668    
Bug Blocks: 20654    
Attachments: Bug 20739: Update two-column templates with Bootstrap grid, Administration part 3
Bug 20739: Update two-column templates with Bootstrap grid, Administration part 3
Bug 20739: Update two-column templates with Bootstrap grid, Administration part 3

Description Owen Leonard 2018-05-09 11:58:05 UTC
This patch will convert even more administration templates to use the Bootstrap grid:

 - categories.tt
 - checkmarc.tt
 - cities.tt
 - classsources.tt
 - clone-rules.tt
 - columns_settings.tt
Comment 1 Owen Leonard 2018-07-16 16:39:30 UTC
Created attachment 77016 [details] [review]
Bug 20739: Update two-column templates with Bootstrap grid, Administration part 3

This patch modifies several acquisitions templates to use the Bootstrap
grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags in the modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Administration -> Columns settings
 - Administration -> Patron categories
   - View and edit patron categories
 - Administration -> Cities and towns
   - View and edit cities
 - Administration -> Classification sources
   - View and edit classification sources
 - Administration -> MARC bibliographic framework test

I'm not sure if this standalone interface is actually in use, but you
can navigate directly to /cgi-bin/koha/admin/clone-rules.pl to see a
form which is usually submitted from the circulation and fines rules
interface. View the page to confirm it looks correct.
Comment 2 Claire Gravely 2018-08-16 09:38:13 UTC
Created attachment 77879 [details] [review]
Bug 20739: Update two-column templates with Bootstrap grid, Administration part 3

This patch modifies several acquisitions templates to use the Bootstrap
grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags in the modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Administration -> Columns settings
 - Administration -> Patron categories
   - View and edit patron categories
 - Administration -> Cities and towns
   - View and edit cities
 - Administration -> Classification sources
   - View and edit classification sources
 - Administration -> MARC bibliographic framework test

I'm not sure if this standalone interface is actually in use, but you
can navigate directly to /cgi-bin/koha/admin/clone-rules.pl to see a
form which is usually submitted from the circulation and fines rules
interface. View the page to confirm it looks correct.

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Comment 3 Jonathan Druart 2018-08-16 19:40:16 UTC
Created attachment 77954 [details] [review]
Bug 20739: Update two-column templates with Bootstrap grid, Administration part 3

This patch modifies several acquisitions templates to use the Bootstrap
grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags in the modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Administration -> Columns settings
 - Administration -> Patron categories
   - View and edit patron categories
 - Administration -> Cities and towns
   - View and edit cities
 - Administration -> Classification sources
   - View and edit classification sources
 - Administration -> MARC bibliographic framework test

I'm not sure if this standalone interface is actually in use, but you
can navigate directly to /cgi-bin/koha/admin/clone-rules.pl to see a
form which is usually submitted from the circulation and fines rules
interface. View the page to confirm it looks correct.

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2018-08-16 19:40:33 UTC
Rebased on top of bug 13618.
Comment 5 Nick Clemens (kidclamp) 2018-08-30 14:09:50 UTC
Awesome work all!

Pushed to master for 18.11
Comment 6 Martin Renvoize 2018-09-05 10:23:34 UTC
Enhancement, will not be backported to 18.05.x series.