Bug 20840

Summary: Internal Server Error when clicking on "Details" button
Product: Koha Reporter: Claudio Costales <costalc>
Component: Fines and feesAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: critical    
Priority: P5 - low CC: fridolin.somers, jonathan.druart, katrin.fischer, martin.renvoize, nick
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 2696    
Bug Blocks:    
Attachments: Internal server error
Further samples
Bug 20840: (bug 2696 follow-up) Fix biblio info fetch
Bug 20840: (bug 2696 follow-up) Fix biblio info fetch
Bug 20840: (bug 2696 follow-up) Fix biblio info fetch

Description Claudio Costales 2018-05-30 21:24:13 UTC
Created attachment 75692 [details]
Internal server error

Internal Server Error when clicking on "Details" button. See file attached.
Comment 1 Katrin Fischer 2018-06-01 05:46:29 UTC
Hi Claudio, I just tried this on master and didn't get an error. Does it happen for all your fine entries?

Can you get to the logs on your system by chance to see the exact error message?
Comment 2 Jonathan Druart 2018-06-01 13:52:47 UTC
You should also see a more meaningful error in the log file.
Comment 3 Claudio Costales 2018-06-01 14:31:15 UTC
Katrin, Jonathan

I cannot identify a more meaningful message in the log files. See a new attached PDF with further  samples.
Comment 4 Claudio Costales 2018-06-01 14:32:21 UTC
Created attachment 75738 [details]
Further samples
Comment 5 Jonathan Druart 2018-06-01 14:58:17 UTC
You should have something in the log file, please double-check :)
Comment 6 Claudio Costales 2018-06-01 15:13:21 UTC
I'm so sorry Jonathan, I have not expressed myself correctly. I checked the log files out but did not identify any meaningful message about this issue. I have checked all log files in /var/log/koha/INSTANCE.
Comment 7 Jonathan Druart 2018-06-01 16:57:33 UTC
Created attachment 75742 [details] [review]
Bug 20840: (bug 2696 follow-up) Fix biblio info fetch

There is no accountlines.biblionumber field, if the account line is
linked to an item, accountline-details.pl will explode with:
Template process failed: undef error - The method biblionumber is not
covered by tests!

Test plan:
Create a fine for a given item
Pay the fine
View the detail of the account line

=> Without this patch you get a software error
=> With this patch applied you will see the biblio's title
Comment 8 Owen Leonard 2018-06-01 17:23:54 UTC
Created attachment 75743 [details] [review]
Bug 20840: (bug 2696 follow-up) Fix biblio info fetch

There is no accountlines.biblionumber field, if the account line is
linked to an item, accountline-details.pl will explode with:
Template process failed: undef error - The method biblionumber is not
covered by tests!

Test plan:
Create a fine for a given item
Pay the fine
View the detail of the account line

=> Without this patch you get a software error
=> With this patch applied you will see the biblio's title

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 9 Claudio Costales 2018-06-01 17:40:22 UTC
Jonathan, finally it works for me!
Comment 10 Katrin Fischer 2018-06-02 21:47:31 UTC
Created attachment 75744 [details] [review]
Bug 20840: (bug 2696 follow-up) Fix biblio info fetch

There is no accountlines.biblionumber field, if the account line is
linked to an item, accountline-details.pl will explode with:
Template process failed: undef error - The method biblionumber is not
covered by tests!

Test plan:
Create a fine for a given item
Pay the fine
View the detail of the account line

=> Without this patch you get a software error
=> With this patch applied you will see the biblio's title

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 11 Nick Clemens (kidclamp) 2018-06-04 17:50:29 UTC
Pushed to master for 18.11, awesome work everybody!
Comment 12 Martin Renvoize 2018-06-05 10:57:18 UTC
This patch has been pushed to 18.05.x and will be in 18.05.01
Comment 13 Fridolin Somers 2018-06-07 07:14:08 UTC
Depends on 2696 not in 17.11.x