Bug 21095

Summary: Tests should expect ccodes facets now (since we have ccode facets)
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: Test SuiteAssignee: Nick Clemens (kidclamp) <nick>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: martin.renvoize
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 18322    
Bug Blocks:    
Attachments: Bug 21095: Add ccode facets info to tests
Bug 21095: Add ccode facets info to tests

Description Nick Clemens (kidclamp) 2018-07-20 02:05:54 UTC
Since bug 18322 added ccode facets to zebra we should expect to get them in tests
Comment 1 Nick Clemens (kidclamp) 2018-07-20 02:08:35 UTC
Created attachment 77146 [details] [review]
Bug 21095: Add ccode facets info to tests

To test:
1 - prove -v t/db_dependent/Search.t
2 - Koha asks "Why am I getting these crazy facets!?!"
3 - Apply patch
4 - prove -v t/db_dependent/Search.t
5 - Koha purrs (tests pass)
Comment 2 Martin Renvoize 2018-07-20 07:19:36 UTC
Created attachment 77151 [details] [review]
Bug 21095: Add ccode facets info to tests

To test:
1 - prove -v t/db_dependent/Search.t
2 - Koha asks "Why am I getting these crazy facets!?!"
3 - Apply patch
4 - prove -v t/db_dependent/Search.t
5 - Koha purrs (tests pass)

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 3 Martin Renvoize 2018-07-20 07:20:32 UTC
Going straight to Passed QA, works as described.. sorry Nick, muppet moment on my part there ;)
Comment 4 Nick Clemens (kidclamp) 2018-07-23 15:38:46 UTC
Awesome work all!

Pushed to master for 18.11
Comment 5 Martin Renvoize 2018-08-02 14:21:19 UTC
Depends on bug 18322 which is not being backported to 18.05.x series.