Bug 21350

Summary: Add Font Awesome icon for pending onsite checkouts link
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Alberto <martinez.alberto>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: fridolin.somers, martin.renvoize, martinez.alberto, nick, severine.queune
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 20322    
Bug Blocks:    
Attachments: Bug 21350: Added icon to Pending on-site checkouts and moved
Bug 21350: Added icon to Pending on-site checkouts and moved
Bug 21350: Added icon to Pending on-site checkouts and moved

Description Owen Leonard 2018-09-14 22:57:48 UTC
If you have enabled on-site checkouts there is a "Pending on-site checkouts" link on the circulation home page. It should have an icon to match the other links on the page. Suggestion:

https://fontawesome.com/v4.7.0/icon/map-marker
Comment 1 Séverine Queune 2018-09-16 22:00:03 UTC
I agree with the suggestion !
Comment 2 Alberto 2018-09-16 23:12:33 UTC Comment hidden (obsolete)
Comment 3 ByWater Sandboxes 2018-09-16 23:23:37 UTC
Created attachment 79028 [details] [review]
Bug 21350: Added icon to Pending on-site checkouts and moved

When pending on-site checkouts is enabled, it will display checkout items that are being used in the library

test plan:
1. Go to Koha administration
2. Search for "onSiteChekouts"
3. Enable "onSitecheckout"
4. Save all Circulation preferences
5. Go back to home page and click "Circulations"
6. Please confirm there is an icon and the link is below Fast cataloging

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Comment 4 Séverine Queune 2018-09-16 23:24:38 UTC
Was weird to have only this button without icon : thanks for fixing it !
Comment 5 Jonathan Druart 2018-09-21 21:05:54 UTC
Created attachment 79257 [details] [review]
Bug 21350: Added icon to Pending on-site checkouts and moved

When pending on-site checkouts is enabled, it will display checkout items that are being used in the library

test plan:
1. Go to Koha administration
2. Search for "onSiteChekouts"
3. Enable "onSitecheckout"
4. Save all Circulation preferences
5. Go back to home page and click "Circulations"
6. Please confirm there is an icon and the link is below Fast cataloging

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Amended patch: replace tabs with 4 spaces
Comment 6 Nick Clemens 2018-09-26 19:37:01 UTC
Awesome work all!

Pushed to master for 18.11
Comment 7 Martin Renvoize 2018-09-27 13:31:36 UTC
Pushed to 18.05.x for 18.05.05
Comment 8 Fridolin Somers 2018-10-08 06:08:38 UTC
Depends on Bug 20322 not in 17.11.x