Description
Marcel de Rooy
2018-10-11 09:56:15 UTC
Created attachment 80391 [details] [review] Bug 21547: Use update_password in opac-passwd and remove sub goodkey Remove sql statement to change password by calling update_password. Remove sub goodkey by calling C4::Auth::checkpw_hash. Test plan: Try to change password in OPAC with good and bad pw. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 80393 [details] [review] Bug 21547: Use update_password in opac-passwd and remove sub goodkey Remove sql statement to change password by calling update_password. Remove sub goodkey by calling C4::Auth::checkpw_hash. Adding the scalar before param Oldkey (from bug 21036). Test plan: Try to change password in OPAC with good and bad pw. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tomas, care to sign this one ? Created attachment 80400 [details] [review] Bug 21547: Use set_password in opac-passwd and remove sub goodkey Remove sql statement to change password by calling set_password. Remove sub goodkey by calling C4::Auth::checkpw_hash. Adding the scalar before param Oldkey (from bug 21036). Rebased on top of 21178 (using set_password instead of update_password). Test plan: Try to change password in OPAC with good and bad pw. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> (In reply to Marcel de Rooy from comment #3) > Tomas, care to sign this one ? Especially since it is now using set_password :) Note that this is no behavior change, since the sql statement did not touch userid either.. Created attachment 82881 [details] [review] Bug 21547: Use set_password in opac-passwd and remove sub goodkey Remove sql statement to change password by calling set_password. Remove sub goodkey by calling C4::Auth::checkpw_hash. Adding the scalar before param Oldkey (from bug 21036). Rebased on top of 21178 (using set_password instead of update_password). Test plan: Try to change password in OPAC with good and bad pw. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 82882 [details] [review] erg goed! Created attachment 82883 [details] [review] Bug 21547: Use set_password in opac-passwd and remove sub goodkey Remove sql statement to change password by calling set_password. Remove sub goodkey by calling C4::Auth::checkpw_hash. Adding the scalar before param Oldkey (from bug 21036). Rebased on top of 21178 (using set_password instead of update_password). Test plan: Try to change password in OPAC with good and bad pw. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> erg goed! (In reply to Tomás Cohen Arazi from comment #9) > erg goed! nudo de lenguaje ? Thx Created attachment 83490 [details] [review] Bug 21547: (follow-up) Rely on Koha::Patron->set_password checks This patch makes the controller just call $patron->set_password and use the exceptions it might raise instead of manually checking the passwor strength. No behaviour change should be expected. It also removes some leftovers. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.02 I chose to backport this architectural change as it's simple cleanup and may aid in future backports. |